Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

disable pointer compression #1593

Merged
merged 1 commit into from
Aug 28, 2024
Merged

disable pointer compression #1593

merged 1 commit into from
Aug 28, 2024

Conversation

devsnek
Copy link
Member

@devsnek devsnek commented Aug 27, 2024 •
edited
Loading

This causes issues with heap cages, limiting the process to 4G of heap, and also may prevent use of upcoming js features like shared structs.

@devsnek devsnek force-pushed the disable-pointer-compression branch from 2b4060c to 3bdf169 Compare August 27, 2024 16:31
bartlomieju
bartlomieju approved these changes Aug 28, 2024
View reviewed changes
Copy link
Member

@bartlomieju bartlomieju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unfortunate, but better to be correct than trade a bit of perf. Please update commit message before landing with the context why we're doing this.

@devsnek devsnek merged commit 48800f8 into main Aug 28, 2024
12 checks passed
@devsnek devsnek deleted the disable-pointer-compression branch August 28, 2024 00:52
@chrisbenincasa chrisbenincasa mentioned this pull request Oct 22, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bartlomieju bartlomieju bartlomieju approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@devsnek @bartlomieju