SMV: use module items for VAR and DEFINE for creating symbols
#1213
+52
−38
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tautschnig
approved these changes
Jul 26, 2025
src/smvlang/smv_typecheck.cpp
Outdated
| check_type(type); | ||
|
|
||
| symbol.base_name = var_it.first; | ||
| symbol.base_name = to_symbol_expr(item.expr).get_identifier(); |
There was a problem hiding this comment.
This re-use of the same symbolt storage makes me a bit uncomfortable. How about creating a fresh symbolt (then using the most suitable constructor) in here and then using symbol_table.insert(std::move(symbol)); instead of symbol_table.add?
The SMV typechecker now uses the module items for creating the symbols for VAR and DEFINE.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The SMV typechecker now uses the module items for creating the symbols for
VARandDEFINE.