Skip to content

Verilog: constant folding for replication #628

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 12, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions regression/verilog/expressions/replication1.v
Original file line number Diff line number Diff line change
Expand Up @@ -21,4 +21,12 @@ module main(in);
always assert property4:
{{ 1 { 1'b0 }}, in } == in;

// constant folding
parameter P = { 2 { 2'b01 } };

wire [P:0] some_wire;

always assert property5:
P == 'b0101;

endmodule
11 changes: 11 additions & 0 deletions src/verilog/verilog_typecheck_expr.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -1552,6 +1552,17 @@ exprt verilog_typecheck_exprt::elaborate_constant_expression(exprt expr)
expr = notequal_exprt(
reduction_or.op(), from_integer(0, reduction_or.op().type()));
}
else if(expr.id() == ID_replication)
{
auto &replication = to_replication_expr(expr);
auto times = numeric_cast_v<std::size_t>(replication.times());
// lower to a concatenation
exprt::operandst ops;
ops.reserve(times);
for(std::size_t i = 0; i < times; i++)
ops.push_back(replication.op());
expr = concatenation_exprt{ops, expr.type()};
}

// We fall back to the simplifier to approximate
// the standard's definition of 'constant expression'.
Expand Down