Cleanup build scripts and upgrade typescript and esbuild #114
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Additionally removes the v8-compile-cache that provides little value in modern node applications of this size. - Adds minification support via esbuild as well as cleaner map files. - Updates package.json "files" property to now only ship required files to npm.
jaerod95
changed the base branch from
master
to
jrod/dit-10044-top-level-cli-branching
marla-hoggard
approved these changes
Apr 8, 2025
Contributor
marla-hoggard
left a comment
marla-hoggard
left a comment
There was a problem hiding this comment.
I don't have a huge amount of context for these changes, but I was able to run yarn start yarn sync and yarn prepublishOnly successfully. prepublishOnly exits with an error, but the same is true on the parent branch, so I think that means it's expected?
jaerod95
added a commit
that referenced
this pull request
Apr 8, 2025
* Moves Legacy CLI into a `legacy` folder and provides a new entrypoint to the beta CLI - adds a `--legacy (-l)` CLI option that forces the application to run in legacy mode. - adds a new warning message when the CLI is run in legacy mode. * Update lib/legacy/index.ts Co-authored-by: Marla Hoggard <[email protected]> * Cleanup build scripts and upgrade typescript and esbuild (#114) * Modernize build system and upgrade esbuild and typescript - Additionally removes the v8-compile-cache that provides little value in modern node applications of this size. - Adds minification support via esbuild as well as cleaner map files. - Updates package.json "files" property to now only ship required files to npm. --------- Co-authored-by: Marla Hoggard <[email protected]>
jaerod95
deleted the
jrod/dit-10048-cleanup-npm-outputs-and-remove-package-warnings-when
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Upgrades typescript and esbuild to latest versions and create a modern build script for bundling the CLI. This removes the need for the
esbuild-node-tscpackage which has been removed from the dev dependnencies list. Theprepublish,start, andsyncscripts have been updated to reflect the new esbuild file.Additionally, drops the use of
v8-compile-cacheto simplify dependencies as the benefits for a cli of this size were minimal at best, and adds a basicCONTRIBUTING.mdfile to house future instructions to describe building and running the CLI locally.Test Plan
yarn installDITTO_API_HOST=http://localhost:3001 yarn startbuilds and runs the plugin application like normal.