[QUIC] Delete ActiveIssues on SupportedLinuxPlatforms_IsSupportedIsTrue test #115141
+0
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR removes the ActiveIssue attributes from the MsQuic platform detection tests to stop excluding Raspbian 10 and related conditions from running in CI.
- Removed three ActiveIssue attributes targeting Raspbian 10, PPC64LE, and Ubuntu2004/S390x issues.
- Adjusted test configuration to now run with the IsInHelix condition on Linux platforms.
Comments suppressed due to low confidence (1)
src/libraries/System.Net.Quic/tests/FunctionalTests/MsQuicPlatformDetectionTests.cs:59
- Removing the ActiveIssue attributes will cause tests to run on platforms that previously had known issues. Please verify that these tests are now adequately covered and can gracefully handle any failures on these platforms.
[ActiveIssue("https://github.com/dotnet/runtime/issues/82154", typeof(PlatformDetection), nameof(PlatformDetection.IsUbuntu2004), nameof(PlatformDetection.IsS390xProcess))]
This was referenced Apr 29, 2025
Open
jkotas
reviewed
Apr 29, 2025
| @@ -57,8 +57,6 @@ public async Task SupportedLinuxPlatformsWithMsQuic_IsSupportedIsTrue() | |||
| } | |||
| } | |||
|
|
|||
| [ActiveIssue("https://github.com/dotnet/runtime/issues/82154", typeof(PlatformDetection), nameof(PlatformDetection.IsPpc64leProcess))] | |||
| [ActiveIssue("https://github.com/dotnet/runtime/issues/82154", typeof(PlatformDetection), nameof(PlatformDetection.IsUbuntu2004), nameof(PlatformDetection.IsS390xProcess))] | |||
There was a problem hiding this comment.
You can delete IsUbuntu2004 property definition as well. This is its last use.
jkotas
reviewed
Apr 29, 2025
| @@ -57,8 +57,6 @@ public async Task SupportedLinuxPlatformsWithMsQuic_IsSupportedIsTrue() | |||
| } | |||
| } | |||
|
|
|||
| [ActiveIssue("https://github.com/dotnet/runtime/issues/82154", typeof(PlatformDetection), nameof(PlatformDetection.IsPpc64leProcess))] | |||
| [ActiveIssue("https://github.com/dotnet/runtime/issues/82154", typeof(PlatformDetection), nameof(PlatformDetection.IsUbuntu2004), nameof(PlatformDetection.IsS390xProcess))] | |||
| [ConditionalFact(typeof(PlatformDetection), nameof(PlatformDetection.IsInHelix))] | |||
There was a problem hiding this comment.
Note for myself: We are not testing Ppc64 and S390x in Helix anymore. This condition will ensure that this test is disabled for Ppc64 and S390x outside of Helix.
jkotas
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #82154
#115129 follow up
cc @jkotas