Skip to content

[QUIC] Delete ActiveIssues on SupportedLinuxPlatforms_IsSupportedIsTrue test #115141

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 30, 2025
Merged

[QUIC] Delete ActiveIssues on SupportedLinuxPlatforms_IsSupportedIsTrue test #115141

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
cca0b21
Raspbian 10 removed from CI
ManickaP Apr 29, 2025
76d6457
Merge branch 'main' into quic-support
ManickaP Apr 30, 2025
9a7b781
Update PlatformDetection.Unix.cs
ManickaP Apr 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion src/libraries/Common/tests/TestUtilities/System/PlatformDetection.Unix.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,6 @@ public static partial class PlatformDetection
public static bool IsLinux => RuntimeInformation.IsOSPlatform(OSPlatform.Linux);
public static bool IsOpenSUSE => IsDistroAndVersion("opensuse");
public static bool IsUbuntu => IsDistroAndVersion("ubuntu");
public static bool IsUbuntu2004 => IsDistroAndVersion("ubuntu", 20, 4);
public static bool IsUbuntu24 => IsDistroAndVersion("ubuntu", 24);
public static bool IsUbuntu24OrHigher => IsDistroAndVersionOrHigher("ubuntu", 24);
public static bool IsDebian => IsDistroAndVersion("debian");
Expand Down
2 changes: 0 additions & 2 deletions src/libraries/System.Net.Quic/tests/FunctionalTests/MsQuicPlatformDetectionTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,8 +57,6 @@ public async Task SupportedLinuxPlatformsWithMsQuic_IsSupportedIsTrue()
}
}

[ActiveIssue("https://github.com/dotnet/runtime/issues/82154", typeof(PlatformDetection), nameof(PlatformDetection.IsPpc64leProcess))]
[ActiveIssue("https://github.com/dotnet/runtime/issues/82154", typeof(PlatformDetection), nameof(PlatformDetection.IsUbuntu2004), nameof(PlatformDetection.IsS390xProcess))]
[ConditionalFact(typeof(PlatformDetection), nameof(PlatformDetection.IsInHelix))]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note for myself: We are not testing Ppc64 and S390x in Helix anymore. This condition will ensure that this test is disabled for Ppc64 and S390x outside of Helix.

[PlatformSpecific(TestPlatforms.Linux)]
public void SupportedLinuxPlatforms_IsSupportedIsTrue()
Expand Down