Skip to content

Rename ASP.NET Core plugin from dotnet-aspnet to dotnet-aspnetcore#711

Merged
AbhitejJohn merged 2 commits into
mainfrom
copilot/rename-dotnet-aspnet-plugin
Jun 8, 2026
Merged

Rename ASP.NET Core plugin from dotnet-aspnet to dotnet-aspnetcore#711
AbhitejJohn merged 2 commits into
mainfrom
copilot/rename-dotnet-aspnet-plugin

Conversation

Copilot AI commented Jun 1, 2026

Copy link
Copy Markdown
Contributor

This updates the ASP.NET Core plugin identity to remove ambiguity with legacy ASP.NET naming. The plugin is now consistently represented as dotnet-aspnetcore across discovery, ownership, marketplace registration, and eval routing.

  • Plugin identity + directory rename

    • Renamed plugin and test roots:
      • plugins/dotnet-aspnetplugins/dotnet-aspnetcore
      • tests/dotnet-aspnettests/dotnet-aspnetcore
    • Updated plugins/dotnet-aspnetcore/plugin.json name to dotnet-aspnetcore.
  • Marketplace + discovery metadata

    • Updated plugin name/source entries in:
      • .github/plugin/marketplace.json
      • .claude-plugin/marketplace.json
      • .cursor-plugin/marketplace.json
    • Updated .vally.yaml plugin key and test path mapping to dotnet-aspnetcore.
  • Ownership + docs alignment

    • Updated .github/CODEOWNERS paths/comments for the renamed plugin/test directories.
    • Updated root README.md plugin table entry/link to dotnet-aspnetcore.
    • Updated issue triage taxonomy label in .github/workflows/issue-triage.md to area-dotnet-aspnetcore.
  • Eval text consistency

    • Updated eval.vally.yaml descriptions under the renamed test tree to reference dotnet-aspnetcore.
// plugins/dotnet-aspnetcore/plugin.json
{
  "name": "dotnet-aspnetcore"
}

Copilot AI linked an issue Jun 1, 2026 that may be closed by this pull request
Copilot AI changed the title [WIP] Rename dotnet-aspnet plugin to dotnet-aspnetcore Rename ASP.NET Core plugin from dotnet-aspnet to dotnet-aspnetcore Jun 1, 2026
Copilot finished work on behalf of lewing June 1, 2026 18:56
Copilot AI requested a review from lewing June 1, 2026 18:56
@github-actions

github-actions Bot commented Jun 1, 2026

Copy link
Copy Markdown
Contributor

Skill Coverage Report

Plugin Skill Covered Coverage
⚠️ dotnet-aspnetcore configuring-opentelemetry-dotnet 13/21 61.9%
⚠️ dotnet-aspnetcore convert-blazor-server-to-webapp 17/27 63%
dotnet-aspnetcore dotnet-webapi 38/43 88.4%
⚠️ dotnet-aspnetcore minimal-api-file-upload 4/8 50%
Uncovered: dotnet-aspnetcore/configuring-opentelemetry-dotnet
  • [Validation] Traces appear in the observability backend (Jaeger, Aspire dashboard, etc.) (line 272)
  • [Validation] HTTP requests automatically create spans with correct verb, URL, status code (line 273)
  • [Validation] Health check endpoints are filtered from traces (line 277)
  • [Validation] Exception details appear on error spans (line 278)
  • [Pitfall] Missing HTTP client spans (line 286)
  • [Pitfall] High cardinality tags (line 287)
  • [CodePattern] readonly (line 124)
  • [CodePattern] [key] (line 241)
Uncovered: dotnet-aspnetcore/convert-blazor-server-to-webapp
  • [Validation] No references to AddServerSideBlazor remain (line 261)
  • [Validation] No references to MapBlazorHub remain (line 262)
  • [Validation] No references to MapFallbackToPage("/_Host") remain (line 263)
  • [Validation] No references to blazor.server.js remain (line 264)
  • [Validation] Pages/_Host.cshtml has been deleted (line 265)
  • [Validation] App builds and runs successfully on the target framework (line 272)
  • [Pitfall] Not migrating AddServerSideBlazor circuit options (line 283)
  • [Pitfall] CSS isolation bundle link has wrong assembly name (line 285)
  • [WorkflowStep] Step 1: Update the project file (line 48)
  • [WorkflowStep] Step 6: Recommended improvements (optional) (line 234)
Uncovered: dotnet-aspnetcore/dotnet-webapi
  • [Validation] DELETE endpoints return 204 No Content (line 464)
  • [Validation] A .http file exists with a request for every new endpoint (line 474)
  • [Validation] dotnet build passes with zero errors and zero warnings (line 475)
  • [CodePattern] [HttpGet] (line 248)
  • [CodePattern] [Range] (line 147)
Uncovered: dotnet-aspnetcore/minimal-api-file-upload
  • [WorkflowStep] Step 1: CRITICAL — Understand IFormFile Binding in Minimal APIs (line 29)
  • [WorkflowStep] Step 5: CRITICAL — Streaming Large Files Without Buffering (line 170)
  • [CodePattern] [FromForm] (line 31)
  • [CodePattern] [RequestSizeLimit] (line 54)

@JanKrivanek

Copy link
Copy Markdown
Member

/evaluate

github-actions Bot added a commit that referenced this pull request Jun 2, 2026
github-actions Bot added a commit that referenced this pull request Jun 2, 2026
@github-actions

github-actions Bot commented Jun 2, 2026

Copy link
Copy Markdown
Contributor

Skill Validation Results

Skill Scenario Quality Skills Loaded Overfit Verdict
convert-blazor-server-to-webapp Blazor Server app with CascadingAuthenticationState 4.0/5 → 5.0/5 🟢 ✅ convert-blazor-server-to-webapp; tools: report_intent, skill ✅ 0.06
minimal-api-file-upload Implement secure file upload in ASP.NET Core 8 minimal API 3.7/5 → 5.0/5 🟢 ✅ minimal-api-file-upload; tools: report_intent, skill / ✅ minimal-api-file-upload; tools: skill ✅ 0.07
minimal-api-file-upload Upload multiple files with metadata in minimal API 3.7/5 → 5.0/5 🟢 ✅ minimal-api-file-upload; tools: report_intent, skill / ✅ minimal-api-file-upload; tools: skill ✅ 0.07
minimal-api-file-upload Stream very large file uploads without buffering 3.7/5 → 5.0/5 🟢 ✅ minimal-api-file-upload; tools: skill ✅ 0.07 [1]
dotnet-webapi Create a CRUD Web API with minimal APIs, OpenAPI, and proper HTTP semantics 2.3/5 → 4.3/5 🟢 ✅ dotnet-webapi; tools: skill / ✅ dotnet-webapi; tools: skill, read_bash, stop_bash 🟡 0.32
dotnet-webapi Add error handling with ProblemDetails and IExceptionHandler 3.7/5 → 4.3/5 🟢 ✅ dotnet-webapi; tools: skill, view / ✅ dotnet-webapi; tools: skill, view, glob 🟡 0.32 [2]
dotnet-webapi Add a new API endpoint to an existing controller-based project 3.0/5 → 4.3/5 🟢 ✅ dotnet-webapi; tools: skill, view / ✅ dotnet-webapi; tools: skill 🟡 0.32
configuring-opentelemetry-dotnet Set up OpenTelemetry tracing and metrics with custom spans in ASP.NET Core 4.0/5 → 5.0/5 🟢 ✅ configuring-opentelemetry-dotnet; tools: report_intent, skill ✅ 0.15
configuring-opentelemetry-dotnet Configure all three OpenTelemetry signals with correct OTLP export 4.0/5 → 5.0/5 🟢 ✅ configuring-opentelemetry-dotnet; tools: skill / ✅ configuring-opentelemetry-dotnet; tools: report_intent, skill ✅ 0.15
configuring-opentelemetry-dotnet Propagate trace context across a message queue 3.0/5 → 5.0/5 🟢 ✅ configuring-opentelemetry-dotnet; tools: skill / ✅ configuring-opentelemetry-dotnet; tools: report_intent, skill ✅ 0.15 [3]

[1] ⚠️ High run-to-run variance (CV=191%) — consider re-running with --runs 5
[2] ⚠️ High run-to-run variance (CV=97%) — consider re-running with --runs 5
[3] ⚠️ High run-to-run variance (CV=56%) — consider re-running with --runs 5

Model: claude-opus-4.6 | Judge: claude-opus-4.6

🔍 Full Results - additional metrics and failure investigation steps

▶ Sessions Visualisation -- interactive replay of all evaluation sessions
📊 Session Analytics (preview) -- aggregated metrics across evaluation sessions

@AbhitejJohn

Copy link
Copy Markdown
Collaborator

@lewing : Are we good with publishing this PR and merging? These changes look good.

@AbhitejJohn AbhitejJohn marked this pull request as ready for review June 8, 2026 16:12
Copilot AI review requested due to automatic review settings June 8, 2026 16:12

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR renames the ASP.NET Core plugin identity from dotnet-aspnet to dotnet-aspnetcore and updates repository metadata so plugin discovery, ownership, marketplace registration, and eval routing all consistently use the new name.

Changes:

  • Updated plugin registration metadata (plugin.json + marketplace manifests) to use dotnet-aspnetcore and the new plugin directory path.
  • Updated eval suite routing and test artifacts under tests/dotnet-aspnetcore/ (including updated eval.vally.yaml descriptions).
  • Updated ownership/docs references (CODEOWNERS, README, issue triage taxonomy label) to match the renamed plugin.
Show a summary per file
File Description
tests/dotnet-aspnetcore/minimal-api-file-upload/eval.yaml Adds/relocates eval scenarios under the renamed plugin test root.
tests/dotnet-aspnetcore/minimal-api-file-upload/eval.vally.yaml Updates eval description to reference dotnet-aspnetcore.
tests/dotnet-aspnetcore/dotnet-webapi/eval.yaml Adds/relocates Web API eval scenarios under the renamed test root.
tests/dotnet-aspnetcore/convert-blazor-server-to-webapp/eval.yaml Adds/relocates Blazor migration eval scenario under the renamed test root.
tests/dotnet-aspnetcore/configuring-opentelemetry-dotnet/eval.yaml Adds/relocates OpenTelemetry eval scenarios under the renamed test root.
tests/dotnet-aspnetcore/configuring-opentelemetry-dotnet/eval.vally.yaml Updates eval description to reference dotnet-aspnetcore.
README.md Updates the plugin table entry/link to dotnet-aspnetcore.
plugins/dotnet-aspnetcore/skills/minimal-api-file-upload/SKILL.md Adds/relocates skill content under the renamed plugin path.
plugins/dotnet-aspnetcore/skills/dotnet-webapi/SKILL.md Adds/relocates skill content under the renamed plugin path.
plugins/dotnet-aspnetcore/skills/convert-blazor-server-to-webapp/SKILL.md Adds/relocates skill content under the renamed plugin path.
plugins/dotnet-aspnetcore/skills/configuring-opentelemetry-dotnet/SKILL.md Adds/relocates skill content under the renamed plugin path.
plugins/dotnet-aspnetcore/plugin.json Renames the plugin name to dotnet-aspnetcore.
.vally.yaml Renames the suite key and updates eval glob to tests/dotnet-aspnetcore/*/eval.vally.yaml.
.github/workflows/issue-triage.md Updates the area label mapping to area-dotnet-aspnetcore.
.github/plugin/marketplace.json Updates marketplace entry to dotnet-aspnetcore and new source path.
.github/CODEOWNERS Updates ownership paths/comments for renamed plugin/test directories.
.cursor-plugin/marketplace.json Updates marketplace entry to dotnet-aspnetcore and new source path.
.claude-plugin/marketplace.json Updates marketplace entry to dotnet-aspnetcore and new source path.

Copilot's findings

Tip

Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

  • Files reviewed: 10/18 changed files
  • Comments generated: 0

@AbhitejJohn AbhitejJohn merged commit 2d163bb into main Jun 8, 2026
38 checks passed
@AbhitejJohn AbhitejJohn deleted the copilot/rename-dotnet-aspnet-plugin branch June 8, 2026 16:20
AbhitejJohn added a commit that referenced this pull request Jun 8, 2026
The Codex CLI requires .codex-plugin/plugin.json as the plugin manifest
entry point. Without it, 'codex plugin add' fails with 'missing plugin.json'
even though the marketplace listing works.

This adds .codex-plugin/plugin.json to all 14 plugin directories, with paths
relative to the plugin root per the Codex docs. Also updates the agents
marketplace to use dotnet-aspnetcore (per #711 rename) and adds missing
dotnet-blazor and dotnet11 entries.

Fixes #578
Fixes #724

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
AbhitejJohn added a commit that referenced this pull request Jun 9, 2026
…726)

The Codex CLI requires .codex-plugin/plugin.json as the plugin manifest
entry point. Without it, 'codex plugin add' fails with 'missing plugin.json'
even though the marketplace listing works.

This adds .codex-plugin/plugin.json to all 14 plugin directories, with paths
relative to the plugin root per the Codex docs. Also updates the agents
marketplace to use dotnet-aspnetcore (per #711 rename) and adds missing
dotnet-blazor and dotnet11 entries.

Fixes #578
Fixes #724

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Rename dotnet-aspnet plugin to dotnet-aspnetcore

5 participants