This repository has been archived by the owner on Jan 13, 2023. It is now read-only.
Security Review Limit Order Contracts #303
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BrendanChou
reviewed
Aug 26, 2019
| @@ -648,6 +652,7 @@ contract LimitOrders is | |||
| returns (bytes memory) | |||
| { | |||
| Require.that( | |||
| // Why not exactly NUM_ORDER_BYTES + NUM_SIGNATURE_BYTES? | |||
There was a problem hiding this comment.
We could do this, but abi.decode uses the same logic (it doesn't care if the bytes array is too long). Thoughts?
| @@ -575,6 +577,7 @@ contract LimitOrders is | |||
| returns (OrderInfo memory) | |||
| { | |||
| Require.that( | |||
| // Should validate it is either exactly NUM_ORDER_BYTES or NUM_ORDER_BYTES + NUM_SIGNATURE_BYTES | |||
There was a problem hiding this comment.
We could do this, but abi.decode uses the same logic (it doesn't care if the bytes array is too long). Thoughts?
There was a problem hiding this comment.
Hmm it seems like in general we should be as specific as possible
| @@ -40,7 +40,9 @@ contract ICallee { | |||
| * @param data Arbitrary data given by the sender | |||
| */ | |||
| function callFunction( | |||
| address sender, | |||
| address sender, // This is set to msg.sender, so this would be the auth proxy for everything... | |||
There was a problem hiding this comment.
Yeah nothing uses it (yet?) but it's already baked-in to the interface
| @@ -461,6 +461,7 @@ contract LimitOrders is | |||
|
|
|||
| // verify taker | |||
| Require.that( | |||
| // Line over max-len, does linter not catch this? | |||
There was a problem hiding this comment.
Investigated and it seems that solium has a bug where it doesn't identify max-len in some cases (if the long line is not the first line of a statement)
| @@ -564,6 +565,7 @@ contract LimitOrders is | |||
| return totalMakerFilledAmount; | |||
| } | |||
|
|
|||
| // Nit: order these helper functions in the order they are used | |||
BrendanChou
reviewed
Aug 27, 2019
BrendanChou
reviewed
Aug 27, 2019
| @@ -210,6 +210,7 @@ contract LimitOrders is | |||
| /** | |||
| * The owner can shut down the exchange. | |||
| */ | |||
| // Need to set these shut downs as immediate functions on multisig | |||
BrendanChou
reviewed
Aug 27, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.