Skip to content
This repository has been archived by the owner on Jan 13, 2023. It is now read-only.

Security Review Limit Order Contracts #303

Closed
wants to merge 5 commits into from
Closed

Security Review Limit Order Contracts #303

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
cdc5c7d
Security review
AntonioJuliano Aug 20, 2019
44a3149
fin
AntonioJuliano Aug 20, 2019
ea1a33e
test
AntonioJuliano Aug 20, 2019
10b1b72
wip -limit orders
AntonioJuliano Aug 22, 2019
809ed0d
fin
AntonioJuliano Aug 27, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion contracts/external/traders/LimitOrders.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -101,7 +101,7 @@ contract LimitOrders is
// ============ Enums ============

enum OrderStatus {
Null,
Null, // Did they ever make that change to solidity where enums are guaranteed to be be 0,1,2,...
Approved,
Canceled
}
Expand Down Expand Up @@ -210,6 +210,7 @@ contract LimitOrders is
/**
* The owner can shut down the exchange.
*/
// Need to set these shut downs as immediate functions on multisig
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

function shutDown()
external
onlyOwner
Expand Down Expand Up @@ -662,6 +663,7 @@ contract LimitOrders is

uint256 sigOffset = NUM_ORDER_BYTES;
/* solium-disable-next-line security/no-inline-assembly */
// Is there a way to do this with abi.decode?
assembly {
let sigStart := add(data, sigOffset)
mstore(add(signature, 0x020), mload(add(sigStart, 0x20)))
Expand Down