[22722] Support interfaces for RPC generated code #5622
Conversation
Signed-off-by: Miguel Company <[email protected]>
Signed-off-by: Miguel Company <[email protected]>
Signed-off-by: Miguel Company <[email protected]>
Signed-off-by: Miguel Company <[email protected]>
Signed-off-by: Miguel Company <[email protected]>
Signed-off-by: Miguel Company <[email protected]>
Signed-off-by: Miguel Company <[email protected]>
Signed-off-by: Miguel Company <[email protected]>
Signed-off-by: Miguel Company <[email protected]>
Signed-off-by: Miguel Company <[email protected]>
MiguelCompany
changed the title
| * | ||
| * @param value The value to read the reply into. | ||
| * | ||
| * @return True if a reply was read, false if the feed has finished. |
There was a problem hiding this comment.
For clarity should read: "false if the feed has finished or has been cancelled".
| * | ||
| * @param value The value to read the reply into. | ||
| * | ||
| * @return True if a reply was read, false if the feed has finished. |
| * Copy write operation. | ||
| * | ||
| * Will add a value to the input feed, that would be eventually sent to the server. | ||
| * May block depending on the configured queue sizes in both the client and the server. |
There was a problem hiding this comment.
Is the queue size part of the default qos in fastdds when configured in either push/pull mode or is it an addition in the RPC implementation?
There was a problem hiding this comment.
There will be new RpcClientQos and RpcServerQos classes that will compose a DataWriterQos and DataReaderQos inside. So the queue sizes mentioned here refer to the ones in the standard HISTORY and RESOURCE_LIMITS QoS
| * @throw RpcBrokenPipeException if the communication with the client breaks. | ||
| * @throw RpcInputFeedCancelledException if the client cancels the input feed. | ||
| */ | ||
| virtual bool read( |
There was a problem hiding this comment.
As an example:
In the event that a database is unable to receive more data due to a lack of storage space, how can this be propagated to the client that the server is unable to process more data?
T type;
while(read(type))
{
// I ran out of space, how do i signal this to the client?
}
There was a problem hiding this comment.
Throwing an exception defined in the IDL, which will be a child of RpcOperationError
There was a problem hiding this comment.
See commit 57d9df2 for documentation improvement of RpcClientWriter
| * @param value The value to write to the replies feed. | ||
| * | ||
| * @throw RpcBrokenPipeException if the communication with the client breaks. | ||
| * @throw RpcTimeoutException if the operation needs to block for a time longer than the configured timeout. |
There was a problem hiding this comment.
Should this call not be able to throw RpcInputFeedCancelledException in the event that the reader prematurely calls cancel()? This also applies to the copy call above
…lledException` Signed-off-by: Miguel Company <[email protected]>
…Exception` Signed-off-by: Miguel Company <[email protected]>
Signed-off-by: Miguel Company <[email protected]>
Signed-off-by: Miguel Company <[email protected]>
@mcheiva I think I addressed all your comments. Could you re-review? |
Description
This adds the generic interfaces that the code generated by Fast DDS Gen for RPC interfaces will use.
Contributor Checklist
versions.mdfile (if applicable).Reviewer Checklist