Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[22624] System Log error: infinite loop when setting thread affinity fails (backport #5611) #5629

Open
wants to merge 1 commit into
base: 3.0.x
Choose a base branch
from

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Feb 6, 2025

When EPROSIMA_LOG_ERROR fails to configure the current thread affinity or scheduler for itself, it causes a new call to EPROSIMA_LOG_ERROR which experiences the same issue, leading to a recursive loop call of the function. To solve this issue, a new function was added, making it so the errors from the log are written as std::cerr instead of calling EPROSIMA_LOG_ERROR.

@Mergifyio backport 3.1.x 3.0.x 2.14.x

Fixes #5524

Contributor Checklist

  • Commit messages follow the project guidelines.

  • The code follows the style guidelines of this project.

  • Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally

  • N/A Any new/modified methods have been properly documented using Doxygen.

  • N/A Any new configuration API has an equivalent XML API (with the corresponding XSD extension)

  • Changes are backport compatible: they do NOT break ABI nor change library core behavior.

  • Changes are API compatible.

  • N/A New feature has been added to the versions.md file (if applicable).

  • N/A New feature has been documented/Current behavior is correctly described in the documentation.

  • Applicable backports have been included in the description.

Reviewer Checklist

  • The PR has a milestone assigned.
  • The title and description correctly express the PR's purpose.
  • Check contributor checklist is correct.
  • If this is a critical bug fix, backports to the critical-only supported branches have been requested.
  • Check CI results: changes do not issue any warning.
  • Check CI results: failing tests are unrelated with the changes.

This is an automatic backport of pull request #5611 done by [Mergify](https://mergify.com).

…5611)

* Refs #22624: Regression test

Signed-off-by: Juanjo Garcia <[email protected]>

* Refs #22624: Corrected bug

Signed-off-by: Juanjo Garcia <[email protected]>

* Refs #22624: improved structure of the test

Signed-off-by: Juanjo Garcia <[email protected]>

* Refs #22624: added reviewer suggestions

Signed-off-by: Juanjo Garcia <[email protected]>

* Refs #22624: fixed reference to new file

Signed-off-by: Juanjo Garcia <[email protected]>

* Refs #22624: fixed typo

Signed-off-by: Juanjo Garcia <[email protected]>

* Refs #22624: Added reviwer suggestions

Signed-off-by: Juanjo Garcia <[email protected]>

* Refs #22624: modified guard

Signed-off-by: Juanjo Garcia <[email protected]>

* Refs #22624: fixed typo

Signed-off-by: Juanjo Garcia <[email protected]>

---------

Signed-off-by: Juanjo Garcia <[email protected]>
(cherry picked from commit 8097762)
@juanjo4936 juanjo4936 added this to the v3.0.2 milestone Feb 6, 2025
@Javgilavi Javgilavi self-requested a review February 6, 2025 07:59
@github-actions github-actions bot added the ci-pending PR which CI is running label Feb 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci-pending PR which CI is running
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant