[22756] Fix error handling logic in try_setting_buffer_size

[MiguelCompany]

Description

This should fix #4684 by applying the last suggested changes

@Mergifyio backport 3.1.x 3.0.x 2.14.x 2.10.x

Contributor Checklist

• Commit messages follow the project guidelines.
• The code follows the style guidelines of this project.
• NO: Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally
• N/A: Any new/modified methods have been properly documented using Doxygen.
• N/A: Any new configuration API has an equivalent XML API (with the corresponding XSD extension)
• Changes are backport compatible: they do NOT break ABI nor change library core behavior.
• Changes are API compatible.
• N/A: New feature has been added to the versions.md file (if applicable).
• N/A: New feature has been documented/Current behavior is correctly described in the documentation.
• Applicable backports have been included in the description.

Reviewer Checklist

• The PR has a milestone assigned.
• The title and description correctly express the PR's purpose.
• Check contributor checklist is correct.
• If this is a critical bug fix, backports to the critical-only supported branches have been requested.
• Check CI results: changes do not issue any warning.
• Check CI results: failing tests are unrelated with the changes.

[juanlofer-eprosima]

Super NIT: I wonder if it's possible that set results in a value greater than the one specified. I guess not, but if that was the case maybe we should fail? Or add an extra check that the value isn't greater than initial_buffer_value, just in case (not trusting asio anymore).