Skip to content

fix: add default parameters to random distributions (requires C++20) #17

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: add default parameters to random distributions (requires C++20) #17

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 6 additions & 5 deletions core/include/algorithms/random.h
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
#pragma once

#include <concepts>
#include <cstdint>
#include <functional>
#include <mutex>
Expand All @@ -26,27 +27,27 @@ class Generator {
public:
Generator(const RandomEngineCB& gen, const size_t cache_size) : m_gen{gen, cache_size} {}

template <class Int = int> Int uniform_int(const Int min, const Int max) const {
template <std::integral Int = int> Int uniform_int(const Int min = 0, const Int max = 1) const {
std::uniform_int_distribution<Int> d{min, max};
std::lock_guard<std::mutex> lock{m_mutex};
return d(m_gen);
}
template <class Float = double> Float uniform_double(const Float min, const Float max) const {
template <std::floating_point Float = double> Float uniform_double(const Float min = 0, const Float max = 1) const {
std::uniform_real_distribution<Float> d{min, max};
std::lock_guard<std::mutex> lock{m_mutex};
return d(m_gen);
}
template <class Int = int> Int poisson(const Int mean) const {
template <std::integral Int = int> Int poisson(const Int mean = 1) const {
std::poisson_distribution<Int> d{mean};
std::lock_guard<std::mutex> lock{m_mutex};
return d(m_gen);
}
template <class Float = double> Float exponential(const Float lambda) const {
template <std::floating_point Float = double> Float exponential(const Float lambda = 1) const {
std::exponential_distribution<Float> d{lambda};
std::lock_guard<std::mutex> lock{m_mutex};
return d(m_gen);
}
template <class Float = double> Float gaussian(const Float mu, const Float sigma) const {
template <std::floating_point Float = double> Float gaussian(const Float mu = 0, const Float sigma = 1) const {
std::normal_distribution<Float> d{mu, sigma};
std::lock_guard<std::mutex> lock{m_mutex};
return d(m_gen);
Expand Down