Skip to content

fix(highlighter): Fix sorting logic for highlighted geometries #2756

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 11 commits into from
Nov 3, 2025
Merged

fix(highlighter): Fix sorting logic for highlighted geometries #2756

merged 11 commits into from
Nov 3, 2025

Conversation

@andrimal
Copy link
Contributor

@andrimal andrimal commented Oct 24, 2025 •
edited
Loading

Summary

The highlighter now respects the series sorting order.

Details

When 2 or more point geometries overlap at the same position (x, y, radius):

  • Highlighted points: They are pre-sorted by sortOrder so the topmost point renders last and its color appears on top
  • Hovered geometries: They are now deduplicated to keep only the topmost point (highest sortOrder), preventing semi-transparent highlight colors from mixing

Screenshots

Kapture 2025-10-31 at 12 04 31

Multiple overlapping points:

Before:
Screenshot 2025-10-30 at 12 32 40 PM

After:
Screenshot 2025-10-31 at 12 05 39 PM

Screenshot 2025-10-31 at 12 03 22 PM

Issues

fix #1921 and fix #2752

Checklist

  • The proper chart type label has been added (e.g. :xy, :partition)
  • The proper feature labels have been added (e.g. :interactions, :axis)
  • All related issues have been linked (i.e. closes #123, fixes #123)
  • The proper documentation and/or storybook story has been added or updated
  • The code has been checked for cross-browser compatibility (Chrome, Firefox, Safari, Edge)
  • Visual changes have been tested with light and dark themes

@andrimal
Copy link
Contributor Author

andrimal commented Oct 30, 2025

buildkite update vrt

@andrimal andrimal added :xy Bar/Line/Area chart related :interactions Interactions related issue labels Oct 30, 2025
@andrimal andrimal marked this pull request as ready for review October 30, 2025 15:02
mariairiartef
mariairiartef reviewed Oct 30, 2025
View reviewed changes
@andrimal
Copy link
Contributor Author

andrimal commented Oct 31, 2025

buildkite update vrt

@andrimal
Copy link
Contributor Author

andrimal commented Oct 31, 2025

buildkite test this

mariairiartef
mariairiartef approved these changes Nov 3, 2025
View reviewed changes
Copy link
Contributor

@mariairiartef mariairiartef left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@andrimal andrimal merged commit 6054ca1 into elastic:main Nov 3, 2025
16 checks passed
nickofthyme pushed a commit that referenced this pull request Nov 7, 2025
@semantic-release-bot
chore(release): 71.1.2 [skip ci]
1928582 
## [71.1.2](v71.1.1...v71.1.2) (2025-11-07)

### Bug Fixes

* **bullet:** fix metric breakpoints in bullet chart ([#2759](#2759)) ([84ad335](84ad335))
* **highlighter:** Fix sorting logic for highlighted geometries ([#2756](#2756)) ([6054ca1](6054ca1))

### Performance Improvements

* **xy:** avoid computing bar value display width ([#2754](#2754)) ([26b1d65](26b1d65))
@andrimal andrimal mentioned this pull request Nov 7, 2025
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mariairiartef mariairiartef mariairiartef approved these changes

Assignees

No one assigned

Labels

:interactions Interactions related issue :xy Bar/Line/Area chart related

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Linechart & Areachart] Hovered dots end up having weird colors due to overlapping Sort highlighter by geometry zIndex

2 participants

@andrimal @mariairiartef