Skip to content

fix(highlighter): Fix sorting logic for highlighted geometries #2756

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Nov 3, 2025
Merged

fix(highlighter): Fix sorting logic for highlighted geometries #2756

Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
0b1c3ea
Updated sorting logic for highlighted geometries
andrimal Oct 24, 2025
2cf5d7b
Move sorting to the pre-sort logic of the matching geometries
andrimal Oct 29, 2025
aa0c595
Enhance highlighting logic for overlapping point geometries
andrimal Oct 29, 2025
991fea2
Add new test for highlighting overlapping point geometries
andrimal Oct 29, 2025
3ea0311
test(vrt): update screenshots [skip ci]
elastic-datavis[bot] Oct 30, 2025
e673e0e
Use key variable for hovered points
andrimal Oct 30, 2025
ffca097
Remove outdated markdown from highlighter z-index story
andrimal Oct 30, 2025
8ddd6e0
Refine sorting logic to ensure consistent rendering order
andrimal Oct 30, 2025
d462ea1
Remove obsolete screenshot for highlighter z-index test
andrimal Oct 30, 2025
d47cf6d
Revert tooltip highlighting logic for overlapping points
andrimal Oct 31, 2025
d12041b
test(vrt): update screenshots [skip ci]
elastic-datavis[bot] Oct 31, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/charts/src/chart_types/xy_chart/renderer/canvas/lines.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ export function renderLines(
};
})
// sort by dimmed first once are rendered ontop of the non-highlighted ones
.sort(({ highlightState }) => (highlightState === 'dimmed' ? -1 : 1))
.sort((a, b) => (a.highlightState === b.highlightState ? 0 : a.highlightState === 'dimmed' ? -1 : 1))
.forEach(({ panel, line, highlightState }) => {
const clippings = getPanelClipping(panel, rotation);
if (line.style.line.visible) {
Expand Down