[Console] Stub window.open in serverless docs test to avoid external tab hang - #288197
Open
kibanamachine wants to merge 1 commit into
Open
[Console] Stub window.open in serverless docs test to avoid external tab hang#288197kibanamachine wants to merge 1 commit into
kibanamachine wants to merge 1 commit into
Conversation
Fixes #253933 The test switched into the external elastic.co docs tab and ran getCurrentUrl() against it, which hung the WebDriver renderer for 300s. Stub window.open to capture the opened URL in-app and assert on it, removing the external-navigation race.
Contributor
Author
|
/flaky ftrConfig:x-pack/platform/test/serverless/functional/configs/search/config.group1.ts:30
|
Contributor
Author
Flaky Test Runner✅ Build triggered - kibana-flaky-test-suite-runner#14156
|
Contributor
Author
Flaky Test Runner Stats🎉 All tests passed! - kibana-flaky-test-suite-runner#14156[✅] x-pack/platform/test/serverless/functional/configs/search/config.group1.ts: 30/30 tests passed. |
kibanamachine
marked this pull request as ready for review
August 31, 2026 21:15
kibanamachine
enabled auto-merge (squash)
August 31, 2026 21:15
Contributor
Author
💛 Build succeeded, but was flaky
Failed CI StepsMetrics [docs]
Test Failures |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #253933
Summary
should open API Reference documentation page when open documentation button is clickedtimed out atretry.try(console.ts:59) withTimed out receiving message from renderer: 300.000.browser.getCurrentUrl()against it; a live external page keeps the renderer busy, so the WebDriver command never returns.window.openbefore the click to capture the URL the app would open, asserts on it in-app, and drops theswitchTab/getCurrentUrl/closeCurrentWindowdance — removing the external-navigation race entirely while keeping the click-wiring coverage (openDocs→window.openwith the resolved docs URL).Context
declare globalWindow augmentation instead ofany/@ts-expect-error, per repo conventions.getDocumentationLink.kibana-on-merge/mainacross two failures ~6 months apart (build 88600, build 108237), always on this one test that opens an external tab — pointing at the external-navigation design, not a random CI hiccup.Verification
Verified locally
✅ Passed:
node scripts/eslint x-pack/platform/test/serverless/functional/test_suites/console/console.tsNot verified locally
Backporting guidance
Applied
backport:versionwithv9.5.3andv9.4.6: the patched file exists at the identical path with the identical faulty pattern on the9.5and9.4release branches, so the patch applies unchanged. Excluded8.19— the test does not exist at this path (or the legacyx-pack/test_serverless/...path) on that branch, so no backport is needed there.Note
Share feedback in #kibana-qa. Mention
@copilotto make quick changes.