Skip to content

[Console] Stub window.open in serverless docs test to avoid external tab hang #288197

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
kibanamachine wants to merge 1 commit into from
+20 −12
Closed

[Console] Stub window.open in serverless docs test to avoid external tab hang #288197

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 20 additions & 12 deletions x-pack/platform/test/serverless/functional/test_suites/console/console.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,12 @@ import expect from '@kbn/expect';
import { DEFAULT_INPUT_VALUE } from '@kbn/console-plugin/common/constants';
import type { FtrProviderContext } from '../../ftr_provider_context';

declare global {
interface Window {
__openedDocUrl: string | null;
}
}

export default function ({ getService, getPageObjects }: FtrProviderContext) {
const retry = getService('retry');
const log = getService('log');
Expand Down Expand Up @@ -48,22 +54,24 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
it('should open API Reference documentation page when open documentation button is clicked', async () => {
await PageObjects.console.clearEditorText();
await PageObjects.console.enterText('GET _search');
await PageObjects.console.clickContextMenu();
await PageObjects.console.clickOpenDocumentationButton();

await retry.tryForTime(10000, async () => {
await browser.switchTab(1);
// Capture the URL the app opens instead of loading the external docs site,
// whose page-load behavior leaves the WebDriver renderer unresponsive.
await browser.execute(() => {
window.__openedDocUrl = null;
window.open = (url) => {
window.__openedDocUrl = url == null ? null : String(url);
return null;
};
});

// Retry until the documentation is loaded
await retry.try(async () => {
const url = await browser.getCurrentUrl();
expect(url).to.contain('/docs/api');
});
await PageObjects.console.clickContextMenu();
await PageObjects.console.clickOpenDocumentationButton();

// Close the documentation tab
await browser.closeCurrentWindow();
await browser.switchTab(0);
await retry.waitFor('documentation URL to be opened', async () => {
const url = await browser.execute(() => window.__openedDocUrl);
return typeof url === 'string' && url.includes('/docs/api');
});
});
});
}
Loading