Fix/issue 1654 #1740
Open
Fix/issue 1654 #1740
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removed skip markers from checklist template tests.
Add TEMPLATE_PATH for accessing checklist templates.
Removed unused TEMPLATE_PATH definition from test file.
SamWilsn
reviewed
Nov 3, 2025
|
|
||
| TEMPLATE_PATH = ( | ||
| Path(__file__).parent.parent.parent.parent | ||
| Path(__file__).parent.parent.parent.parent.parent.parent.parent |
There was a problem hiding this comment.
Can we use .parents[...] instead of chaining so many parent traversals together?
There was a problem hiding this comment.
Can we use
.parents[...]instead of chaining so manyparenttraversals together?
yes using parents index will be much better. but i went with chained calls cause in previous code they were using it
| skipped=0, | ||
| errors=0, | ||
| ) | ||
| result.assert_outcomes(errors=0) |
There was a problem hiding this comment.
Why is this necessary?
initially i made those changes cause checking errors=0 was enough to prove code path didn't crash, i'll undo the changes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🗒️ Description
This PR addresses Issue #1645 by re-enabling two sets of EEST unit tests that were previously disabled due to the missing docs subtree dependency.
To ensure the re-enabled tests run correctly after the repository refactoring, the file path constant pointing to the documentation template (TEMPLATE_PATH) was corrected to use an 8-level directory traversal in the following files:
packages/testing/.../test_checklist_template_consistency.py
packages/testing/.../eip_checklist.py
All re-enabled tests pass successfully on the latest build.
🔗 Related Issues or PRs
Fixes #1645
✅ Checklist
toxchecks to avoid unnecessary CI fails, see also Code Standards and Enabling Pre-commit Checks:uvx tox -e statictype(scope):.mkdocs servelocally and verified the auto-generated docs for new tests in the Test Case Reference are correctly formatted.@ported_frommarker.Cute Animal Picture