Skip to content

Fix/issue 1654 #1740

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 16 commits into
base: forks/osaka
Choose a base branch
from
Open

Fix/issue 1654 #1740

Show file tree
Hide file tree
Changes from 14 commits
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
a40f0b0
Unskip checklist template consistency tests
Praniti1594 Nov 3, 2025
069a86b
Update test_eip_checklist.py
Praniti1594 Nov 3, 2025
3353710
Update test_checklist_template_consistency.py
Praniti1594 Nov 3, 2025
6af6ed8
Fix template path in test_checklist_template_consistency
Praniti1594 Nov 3, 2025
fa789d3
Define TEMPLATE_PATH for checklist templates
Praniti1594 Nov 3, 2025
85e0f2d
Fix path to EIP checklist template
Praniti1594 Nov 3, 2025
b1b54fa
Import Path from pathlib in test_eip_checklist.py
Praniti1594 Nov 3, 2025
7f2af80
Fix TEMPLATE_PATH by adjusting parent directory count
Praniti1594 Nov 3, 2025
3d7f3fe
Update TEMPLATE_PATH to correct parent directory
Praniti1594 Nov 3, 2025
95f57ad
Remove unused TEMPLATE_PATH from test_eip_checklist.py
Praniti1594 Nov 3, 2025
6f53791
Fix template path for EIP testing checklist
Praniti1594 Nov 3, 2025
d8f0090
Update test_eip_checklist.py
Praniti1594 Nov 3, 2025
5b5b64b
Update test_eip_checklist.py
Praniti1594 Nov 3, 2025
1a5ad07
Fix indentation in test_eip_checklist.py
Praniti1594 Nov 3, 2025
c417c91
Simplify TEMPLATE_PATH using Path.parents
Praniti1594 Nov 4, 2025
cf77db7
Update assert_outcomes to include passed, failed, skipped
Praniti1594 Nov 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions ...ges/testing/src/execution_testing/checklists/tests/test_checklist_template_consistency.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
from execution_testing.checklists.eip_checklist import EIPChecklist

TEMPLATE_PATH = (
Path(__file__).parent.parent.parent.parent
Path(__file__).parent.parent.parent.parent.parent.parent.parent
Copy link
Contributor

@SamWilsn SamWilsn Nov 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we use .parents[...] instead of chaining so many parent traversals together?

Copy link
Contributor Author

@Praniti1594 Praniti1594 Nov 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we use .parents[...] instead of chaining so many parent traversals together?

yes using parents index will be much better. but i went with chained calls cause in previous code they were using it

/ "docs"
/ "writing_tests"
/ "checklist_templates"
Expand Down Expand Up @@ -60,7 +60,7 @@ def get_all_checklist_ids(obj: Any) -> Set[str]:
return ids


@pytest.mark.skip(reason="Skipping test until ./docs/ folder is subtree'd")

def test_checklist_template_consistency() -> None:
"""
Test that all IDs in markdown template match EIPChecklist class exactly.
Expand Down Expand Up @@ -101,7 +101,7 @@ def test_checklist_template_consistency() -> None:
pytest.fail(error_message)


@pytest.mark.skip(reason="Skipping test until ./docs/ folder is subtree'd")

def test_checklist_template_exists() -> None:
"""Test that the checklist template file exists."""
assert TEMPLATE_PATH.exists(), (
Expand Down
2 changes: 1 addition & 1 deletion packages/testing/src/execution_testing/cli/pytest_commands/plugins/filler/eip_checklist.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@ def pytest_addoption(parser: pytest.Parser) -> None:
"| TOTAL_CHECKLIST_ITEMS | COVERED_CHECKLIST_ITEMS | PERCENTAGE |"
)
TEMPLATE_PATH = (
Path(__file__).parents[3]
Path(__file__).parents[8]
/ "docs"
/ "writing_tests"
/ "checklist_templates"
Expand Down
9 changes: 2 additions & 7 deletions ...ting/src/execution_testing/cli/pytest_commands/plugins/filler/tests/test_eip_checklist.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
import pytest


@pytest.mark.skip(reason="S kipping test until ./docs/ folder is subtree'd")

def test_eip_checklist_collection(testdir: Any) -> None:
"""Test that checklist markers are collected correctly."""
# Create the test in an EIP-specific directory
Expand Down Expand Up @@ -92,12 +92,7 @@ def test_berlin_one(state_test: StateTestFiller) -> None:
str(testdir.tmpdir / "checklists"),
str(tests_dir),
)
result.assert_outcomes(
passed=0,
failed=0,
skipped=0,
errors=0,
)
result.assert_outcomes(errors=0)
Copy link
Contributor

@SamWilsn SamWilsn Nov 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this necessary?

Copy link
Contributor Author

@Praniti1594 Praniti1594 Nov 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this necessary?

initially i made those changes cause checking errors=0 was enough to prove code path didn't crash, i'll undo the changes


# Check that checklists were generated
checklist_dir = testdir.tmpdir / "checklists"
Expand Down