fix: add missing T2TT and T2ST task choices to CLI predict#572
Open
Mr-Neutr0n wants to merge 1 commit intofacebookresearch:mainfrom
Open
fix: add missing T2TT and T2ST task choices to CLI predict#572Mr-Neutr0n wants to merge 1 commit intofacebookresearch:mainfrom
Mr-Neutr0n wants to merge 1 commit intofacebookresearch:mainfrom
Conversation
The CLI predict command only accepts ASR, S2ST, and S2TT as task choices, but the underlying Translator.predict() supports T2TT (text-to-text translation) and T2ST (text-to-speech translation). The main() function already handles these tasks correctly (lines 204, 227-233), but argparse rejects them at argument validation. Add T2TT and T2ST to the choices list, update the help text, and add a validation check requiring src_lang for text input tasks. Fixes facebookresearch#476
meta-cla
bot
added
the
CLA Signed
Author
|
Friendly bump! Let me know if there's anything I should update or improve to help move this forward. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The CLI
predictcommand only acceptsASR,S2ST, andS2TTas task choices, but the underlyingTranslator.predict()supports all five tasks includingT2TT(text-to-text translation) andT2ST(text-to-speech translation).The
main()function already handles text input tasks correctly — it checks forT2STat the output path validation and routes text input through the else branch — but argparse rejectsT2TTandT2STat argument validation before the code can run.Changes
T2TTandT2STto the--taskargument choices--src_langfor text input tasks (T2TT,T2ST)Fixes #476