Skip to content

fix: add missing T2TT and T2ST task choices to CLI predict #572

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Mr-Neutr0n wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: add missing T2TT and T2ST task choices to CLI predict #572

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion src/seamless_communication/cli/m4t/predict/predict.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,11 +27,13 @@ def add_inference_arguments(parser: argparse.ArgumentParser) -> argparse.Argumen
parser.add_argument(
"--task",
type=str,
choices=["ASR", "S2ST", "S2TT"],
choices=["ASR", "S2ST", "S2TT", "T2ST", "T2TT"],
help=(
"* `ASR` -- automatic speech recognition (transcription);"
"* `S2ST` -- speech to speech translation;"
"* `S2TT` -- speech to text translation;"
"* `T2ST` -- text to speech translation;"
"* `T2TT` -- text to text translation;"
)
)
parser.add_argument(
Expand Down Expand Up @@ -201,6 +203,11 @@ def main() -> None:
"Please provide required arguments for evaluation - task, tgt_lang"
)

if args.task.upper() in {"T2TT", "T2ST"} and args.src_lang is None:
raise ValueError(
"src_lang must be provided for text input tasks (T2TT, T2ST)"
)

if args.task.upper() in {"S2ST", "T2ST"} and args.output_path is None:
raise ValueError("output_path must be provided to save the generated audio")

Expand Down