Test PR for new Retry Framework #19
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kpedro88
reviewed
Apr 2, 2025
kpedro88
reviewed
Apr 7, 2025
kpedro88
reviewed
Apr 7, 2025
kpedro88
reviewed
Apr 7, 2025
kpedro88
reviewed
Jul 7, 2025
| @@ -65,6 +65,7 @@ class TritonClient : public SonicClient<TritonInputMap, TritonOutputMap> { | |||
| bool handle_exception(F&& call); | |||
|
|
|||
| void reportServerSideStats(const ServerSideStats& stats) const; | |||
| void updateServer(std::string serverName); | |||
| @@ -574,6 +561,26 @@ inference::ModelStatistics TritonClient::getServerSideStatus() const { | |||
| return inference::ModelStatistics{}; | |||
| } | |||
|
|
|||
| void TritonClient::updateServer(std::string serverName){ | |||
| useSharedMemory = cms.untracked.bool(not options.noShm), | ||
| compression = cms.untracked.string(options.compression), | ||
| Retry = cms.VPSet( |
There was a problem hiding this comment.
should rebase on latest 15_1_X prerelease (to incorporate cms-sw#47748)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR description:
Implements a
RetryActionBaseclass for different types of action to be taken upon the need to retry.SonicClientBasewill have a list ofRetryActionpointers initialized at construction.The client will retry the list of actions one-by-one until every actions is no-longer suitable to retry.
An example configuration may look like this: