Repository navigation
Conversation
Start canceling the source subscription without waiting for the active mapped subscription's cancellation to complete, so a slow mapped cleanup no longer delays releasing the source.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Status
READY
Breaking Changes
NO
Description
When the output of
droppable()is cancelled, the transformer used to await the active mapped subscription's cancellation before it started cancelling the source subscription. A slow mapped cleanup therefore delayed releasing the source. Now both cancellations start immediately and are awaited together withFuture.wait, so an error from either one still propagates. This is the same pattern bloc's internal flat-map transformer uses.Tests:
In a local benchmark where the mapped cancellation takes about 100ms, the source is now released in under 1ms instead of after about 105ms.
Type of Change