feat: slim down shared #1986
Merged
feat: slim down shared #1986
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Stebalien
force-pushed
the
steb/reduce-shared
branch
from
db98818 to
0e02830
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1986 +/- ##
===========================================
- Coverage 75.52% 60.37% -15.16%
===========================================
Files 158 116 -42
Lines 15600 10568 -5032
===========================================
- Hits 11782 6380 -5402
- Misses 3818 4188 +370
|
Stebalien
force-pushed
the
steb/reduce-shared
branch
from
0e02830 to
ab50ad1
Compare
|
IIRC, this was in draft pending merging stuff in the built-in actors, but we might as well merge it now. |
- `BLOCK_GAS_LIMIT`: Neither the FVM nor the builtin actors care about the block gas limit. And if they did, it would have to be a runtime parameter passed from the client. - `EPOCH_DURATION_SECONDS`: Different networks may have different block times, this constant is useless. - `math`, `reward`, `smooth`: part of the reward actor calculations, not relevant to the FVM itself (moved to the builtin actors). - `TOTAL_FILECOIN`, `TOTAL_FILECOIN_BASE`: Network parameter, not a concern of the FVM. - `BLOCKS_PER_EPOCH`: protocol parameter, moved to the builtin actors. - `MAX_SECTOR_NUMBER`: moved to the builtin actors. - `Spacetime`, `SectorQuality`: moved to the builtin actors. - `ZERO_ADDRESS`, `*_LOOKBACK`, `ALLOWABLE_CLOCK_DRIFT`, `NetworkParams`, `DefaultNetworkParams`: unused.
Stebalien
force-pushed
the
steb/reduce-shared
branch
from
ab50ad1 to
7dcd7b9
Compare
rvagg
reviewed
Apr 1, 2025
rvagg
approved these changes
Apr 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BLOCK_GAS_LIMIT: Neither the FVM nor the builtin actors care about the block gas limit. And if they did, it would have to be a runtime parameter passed from the client.EPOCH_DURATION_SECONDS: Different networks may have different block times, this constant is useless.math,reward,smooth: part of the reward actor calculations, not relevant to the FVM itself (moved to the builtin actors).TOTAL_FILECOIN,TOTAL_FILECOIN_BASE: Network parameter, not a concern of the FVM.BLOCKS_PER_EPOCH: protocol parameter, moved to the builtin actors.MAX_SECTOR_NUMBER: moved to the builtin actors.Spacetime,SectorQuality: moved to the builtin actors.ZERO_ADDRESS,*_LOOKBACK,ALLOWABLE_CLOCK_DRIFT,NetworkParams,DefaultNetworkParams: unused.