Feature: Added support for bulk rename #16228
Conversation
| !string.IsNullOrEmpty(fileName) && !IsNameValid; | ||
|
|
||
|
|
||
| private string fileName = string.Empty; |
There was a problem hiding this comment.
| private string fileName = string.Empty; | |
| private string _FileName = string.Empty; |
There was a problem hiding this comment.
Isn't the '_' prefix against the code style rules for C#? I think it's IDE1006
https://learn.microsoft.com/en-gb/dotnet/fundamentals/code-analysis/style-rules/naming-rules
There was a problem hiding this comment.
This is a private field. Using PascalCase is guided by our coding guideline, Section 2, Number 2.
Use PascalCase prefixed with _ for properties’ backing fields
There was a problem hiding this comment.
Oh yeah, I forgot why that seemed so familiar...
| } | ||
|
|
||
| // Commands | ||
| public IAsyncRelayCommand CommitRenameCommand { get; private set; } |
There was a problem hiding this comment.
| public IAsyncRelayCommand CommitRenameCommand { get; private set; } | |
| public IAsyncRelayCommand CommitRenameCommand { get; private set; } |
| false | ||
| ); | ||
| })); | ||
|
|
| private FrameworkElement RootAppElement | ||
| => (FrameworkElement)MainWindow.Instance.Content; | ||
|
|
||
| public BulkRenameDialogViewModel ViewModel |
There was a problem hiding this comment.
This has been a bad practice and I was going to delete.
Can you use binding instead?
There was a problem hiding this comment.
I don't think that works for IDialog.
| InitializeComponent(); | ||
| } | ||
|
|
||
| public new async Task<DialogResult> ShowAsync() |
There was a problem hiding this comment.
Shouldn't this be public override async? Or is this intended?
|
|
||
| <StackPanel Width="440" Spacing="4"> | ||
|
|
||
| <!-- Name --> |
There was a problem hiding this comment.
<!-- Name -->
What does this mean?
There was a problem hiding this comment.
A comment for the block named "Name" in the Bulk Rename dialog
There was a problem hiding this comment.
Will you add error handling? Or is it automatic?
There was a problem hiding this comment.
It should be handled by RenameAsync.
| mc:Ignorable="d"> | ||
|
|
||
| <StackPanel Width="440" Spacing="4"> | ||
|
|
There was a problem hiding this comment.
I already suggested changes for all of them here.
There was a problem hiding this comment.
These are different changes.
There was a problem hiding this comment.
It's a preference to have spaces between xaml blocks.
There was a problem hiding this comment.
Yes I know, this is just not the same as in other files.
There was a problem hiding this comment.
The style has evolved over the years
There was a problem hiding this comment.
These are different changes.
I misunderstood, sorry.
| </TextBox> | ||
|
|
||
| </Grid> | ||
|
|
| } | ||
| } | ||
|
|
||
| // Commands |
There was a problem hiding this comment.
| // Commands | |
| // Commands | |
Resolved / Related Issues
To prevent extra work, all changes to the Files codebase must link to an approved issue marked as
Ready to build. Please insert the issue number following the hashtag with the issue number that this Pull Request resolves.Steps used to test these changes
Stability is a top priority for Files and all changes are required to go through testing before being merged into the repo. Please include a list of steps that you used to test this PR.