Closed
Conversation
osa1
commented
Jan 22, 2026
osa1
commented
Jan 22, 2026
osa1
commented
Jan 22, 2026
This was referenced Jan 25, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TODO:
The types returned during lowering are not quite right in some cases.. How are they used? Check if we can remove them.
If and match expressions are handled in a really hacky way. We don't know their types, try to "infer" them in a hacky way during lowering, and then add a bunch of hacks on top in C gen to handle branches that return different typed, but ignored, values. (i.e. when type of the whole thing is
())We should just add types to all front-end expressions (front-end, mono, lowered). It was fine in the past as the interpreter didn't care about the types and the initial C backend had everything as
uint64_t, but clearly they're useful and even required in many cases if we want to generate typed code.