Skip to content

docs(storage-resize-images): document EXT_SELECTED_EVENTS - #3285

Open
IzaakGough wants to merge 2 commits into
kitsfrom
docs/kits-resize-images-selected-events
Open

IzaakGough wants to merge 2 commits into
kitsfrom
docs/kits-resize-images-selected-events

Conversation

@IzaakGough

Copy link
Copy Markdown
Contributor

Fixes #3273.

The README did not say which .env key picks the published event types, so a user copying their extension .env got every event.

This documents EVENTARC_CHANNEL and EXT_SELECTED_EVENTS in the configuration table and Events section, matching the firestore-bigquery-export kit.

Checked against the kit and firebase-admin source. Not tested with a deploy.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the README.md for the storage-resize-images kit to document the EVENTARC_CHANNEL and EXT_SELECTED_EVENTS environment variables. The review feedback suggests a minor rephrasing of the explanation for EXT_SELECTED_EVENTS to make it more professional and clear.

Comment thread kits/storage-resize-images/README.md Resolved
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

decision(storage-resize-images): kit/extension parity – ALLOWED_EVENT_TYPES is ignored, the kit reads EXT_SELECTED_EVENTS

1 participant