Add LinkDomain to ActionCodeSettings #682
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Could someone take a look at this PR? (and related issue) Firebase dynamic links will be shutdown on Aug 25, and I am hoping to be migrated off of dynamic links by the end of April, to ensure a comfortable buffer time before the shutdown deadline. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Discussion
Add the
LinkDomainfield to theActionCodeSettingsstruct, this new field enables migrating off of firebase dynamic links, which is deprecated and will be unsupported soon.See issue #681
Testing
Unit test is updated to check that
linkDomainis set correctly in the action code settings map.I haven't tested the backend service to confirm it will accept this new parameter, but it looks like this should be the only change required, since the nodeJS SDK already includes the
linkDomainfield.API Changes
N/A