feat/pipeline/private-preview to main #15625

cherylEnkidu · 2025-12-19T00:21:38Z

No description provided.

Co-authored-by: wu-hui <[email protected]> Co-authored-by: Nick Cooke <[email protected]>

Co-authored-by: Morgan Chen <[email protected]>

…ode/` directory (#14833) Co-authored-by: Morgan Chen <[email protected]>

…14855)

…ervice/` directory (#14839) Co-authored-by: Morgan Chen <[email protected]>

Co-authored-by: Morgan Chen <[email protected]>

Co-authored-by: wu-hui <[email protected]>

…ons could not be passed across actor boundaries (#15467)

Co-authored-by: wu-hui <[email protected]>

Co-authored-by: cherylEnkidu <[email protected]>

Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>

gemini-code-assist · 2025-12-19T00:21:42Z

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

google-cla · 2025-12-19T00:22:04Z

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

cherylEnkidu · 2025-12-19T00:27:17Z

.github/workflows/firestore.yml


    - name: Build and test
      run: |
-        export EXPERIMENTAL_MODE=true


Looks this this flag was added by mistake in MIEQ PR: 8d66bdc The intention of the given commit is to use latest emulator. So I remove these export EXPERIMENTAL_MODE=true here.

cherylEnkidu · 2025-12-19T00:28:51Z

.github/workflows/firestore.yml

      platforms: iOS
      buildonly_platforms: iOS

-  check-firestore-internal-public-headers:


Remove these check since right now the not all of public APIs of objective C files are intend to use by customers.

cherylEnkidu · 2025-12-19T01:35:01Z

Firestore/CHANGELOG.md

+# Unreleased
+- [feature] Add `Pipeline` support.
+- [fixed] Fixed an issue where the returned object in transaction blocks could not
+  pass across actor boundaries in Swift 6 (#15467).


wu-hui

Some ultranits.

wu-hui · 2025-12-19T15:04:18Z

FirebaseMessaging/Sources/FIRMessagingRmqManager.m

      flags |= SQLITE_OPEN_FILEPROTECTION_NONE;
 #endif
-      int result = sqlite3_open_v2([path UTF8String], &self -> _database, flags, NULL);
+      int result = sqlite3_open_v2([path UTF8String], &self->_database, flags, NULL);


This is likely from clang-format?

Yes, I will revert this one

wu-hui · 2025-12-19T15:05:11Z

Firestore/CHANGELOG.md

@@ -1,3 +1,8 @@
+# Unreleased
+- [feature] Add `Pipeline` support.


Maybe call out it is a public preview feature.

wu-hui · 2025-12-19T15:08:37Z

Firestore/Example/Tests/SpecTests/FSTSpecTests.mm

 - (void)testSpecTests {
  if ([self isTestBaseClass]) return;

+  // LogSetLevel(firebase::firestore::util::kLogLevelDebug);


Just delete?

wu-hui · 2025-12-19T15:08:50Z

Firestore/Example/Tests/SpecTests/FSTSpecTests.mm

      } else {
        ++testSkipCount;
-        NSLog(@"  [SKIPPED] Spec test: %@", name);
+        // NSLog(@"  [SKIPPED] Spec test: %@", name);


Seems like we should bring it back?

wu-hui · 2025-12-19T15:13:00Z

Firestore/Source/API/FIRFirestore+Internal.h

@@ -1,5 +1,5 @@
 /*
- * Copyright 2017 Google
+ * Copyright 2025 Google LLC


cherylEnkidu and others added 30 commits March 13, 2025 10:18

create main branch of ppl

574db2e

Add ppl protos (#14516)

7a4a98c

End-to-end minimalistic ppl (#14546)

0cd0224

Add C++ stages/expressions and Constant value support (#14588)

15046ff

Merge branch 'main' into cheryllin/ppl

ce1bb03

Manually set cmake version

abd8560

Update firestore.yml

fc8220f

set flag

54b5b9f

Merge branch 'cheryllin/fixcmake' into cheryllin/ppl

aa6570d

merge in main

3ba08d6

Ppl API (#14513)

11ae3e2

Co-authored-by: wu-hui <[email protected]> Co-authored-by: Nick Cooke <[email protected]>

Pipeline tests part 1 (#14885)

7cafce4

Co-authored-by: wu-hui <[email protected]> Co-authored-by: Nick Cooke <[email protected]>

Pipeline tests part 2 (#14951)

432064a

Co-authored-by: wu-hui <[email protected]> Co-authored-by: Nick Cooke <[email protected]>

Fix type warnings for size_t use in Firestore (#14790)

bc58652

[Firebase AI] Add support for Gemma models with Developer API (#14823)

b68369f

Analytics 11.13.0 (#14824)

da813ba

[Release] Update Package.swift for M164 release (#14828)

51779cf

[Infra] Add FIRAllocatedUnfairLock type (#14825)

a1e330d

Co-authored-by: Morgan Chen <[email protected]>

[Firebase AI] Update error domain constant for renamed SDK (#14829)

d624f8a

[Auth] Add Swift 6 conformance to `FirebaseAuth/Sources/Swift/ActionC…

bf822b1

…ode/` directory (#14833) Co-authored-by: Morgan Chen <[email protected]>

[Functions] More Swift 6 improvements (#14788)

baa6fb8

add FirebaseAI to release notes (#14840)

bd6fae7

[Functions] Complete Swift 6 support (#14838)

9b1b647

[Firebase AI] Update Gemma candidate token count integration tests (#…

45d1d2c

…14855)

[Auth] Add Swift 6 conformance to `FirebaseAuth/Sources/Swift/SystemS…

0b78a27

…ervice/` directory (#14839) Co-authored-by: Morgan Chen <[email protected]>

[Firebase AI] Upload xcodebuild logs in integration tests (#14844)

9daa421

[Firebase AI] Update CHANGELOG entry wording (#14857)

6e562a0

Bind rmqID instead of using stringWithFormat. (#14856)

79f584a

[Swift 6] Add Swift 6 testing for Sessions (#14599)

20e7382

Co-authored-by: Morgan Chen <[email protected]>

[Auth] Conform 'AuthKeychainServices' to 'Sendable' (#14862)

d259d88

cherylEnkidu and others added 13 commits October 20, 2025 11:32

fix re2 spm build

178998d

change cmake and cocoapods for re2

b1c17f7

Add documentation for ppl (#15401)

680503d

Co-authored-by: wu-hui <[email protected]>

Remove null / nan related operations (#15441)

56a44fa

Co-authored-by: wu-hui <[email protected]>

merge in main

e31449e

Add checking for duplicate alias (#15449)

e65a3a0

Co-authored-by: wu-hui <[email protected]>

Fix an issue where Swift complained that the sent object in transacti…

81cce2d

…ons could not be passed across actor boundaries (#15467)

Add missing expressions (#15457)

5a2cc6b

Co-authored-by: wu-hui <[email protected]>

Merge branch 'main' into feat/pipeline/private-preview

ca9b710

Fix format errors (#15485)

83d0a4e

Co-authored-by: cherylEnkidu <[email protected]>

Add Expression.asBoolean() (#15547)

1c5745b

Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>

Use grpc streaming reader for pipeline execution (#15577)

a693b2a

Fix CI for pipeline (#15594)

39d4a9e

Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>

google-oss-bot added api: firestore api: messaging public-api-change labels Dec 19, 2025

cherylEnkidu commented Dec 19, 2025

View reviewed changes

cherylEnkidu added 2 commits December 18, 2025 21:32

fix duplicate in gitignore

78a0b98

Merge branch 'main' into feat/pipeline/private-preview

f52bf69

cherylEnkidu assigned egilmorez Dec 19, 2025

wu-hui approved these changes Dec 19, 2025

View reviewed changes

cherylEnkidu added 5 commits December 19, 2025 11:41

address feedbacks

f35c1ea

format code

4bb1fb0

increase timeout minutes

e982956

correct timeout place

52ebe18

fix ci

dd90085

		@@ -1,3 +1,8 @@
		# Unreleased
		- [feature] Add `Pipeline` support.

feat/pipeline/private-preview to main #15625

Are you sure you want to change the base?

feat/pipeline/private-preview to main #15625

Uh oh!

Conversation

cherylEnkidu commented Dec 19, 2025

Uh oh!

gemini-code-assist bot commented Dec 19, 2025

Uh oh!

google-cla bot commented Dec 19, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

wu-hui left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

18 participants