-
Notifications
You must be signed in to change notification settings - Fork 1.7k
feat/pipeline/private-preview to main #15625
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from 148 commits
574db2e
7a4a98c
0cd0224
15046ff
ce1bb03
abd8560
fc8220f
54b5b9f
aa6570d
3ba08d6
11ae3e2
7cafce4
432064a
bc58652
b68369f
da813ba
51779cf
a1e330d
d624f8a
bf822b1
baa6fb8
bd6fae7
9b1b647
45d1d2c
0b78a27
9daa421
6e562a0
79f584a
20e7382
d259d88
116c6d6
baa78c4
314feae
946b16e
5eeffe5
e70047d
2489cd0
ca714bf
7682cb9
c04eb62
f57e553
0cf3d55
b4d58b2
fbb8458
61f6af3
35e0adb
f3075b1
e9427cc
379bcc9
19f6c36
f8d111e
dba5238
4f6ea24
16a0fef
02300e2
b170155
9bb64a2
f991be1
b4b6c81
8174544
572228d
4aba365
de72981
d5e993c
1045d44
78461e8
62942a1
4238479
4b69595
8752b16
5f2ba26
3dad2f1
97562e7
70cd2ff
718df02
334c2b8
d62c7a2
782689c
5e1ece4
06042b6
cf262da
9b7b370
b54e68e
343bda6
56b4128
3b76a1b
1c56726
cf99a3c
fa3529a
3879094
676a24d
01a7794
0d4728b
a00029b
3027569
e05b238
d2e2ed0
318edd4
a945ff3
bb17e64
dde003c
d6c8c21
ca966a2
8f785fc
3fe56e9
4238fd8
17f6f81
6482013
3a552e9
f4024f0
1450754
ddcd6e9
25f2f46
5af1fdb
f89ea76
c3cc79a
33bc889
8e1eebc
7c1bbd4
9685284
8e0695d
bc6a400
266aacf
2c5f607
2787ede
68e64f0
042515a
dde6ee9
59aa81d
a3e4b27
e6fe909
36f90ef
a655bde
178998d
b1c17f7
680503d
56a44fa
e31449e
e65a3a0
81cce2d
5a2cc6b
ca9b710
83d0a4e
1c5745b
a693b2a
39d4a9e
78a0b98
f52bf69
f35c1ea
4bb1fb0
e982956
52ebe18
dd90085
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -157,7 +157,6 @@ jobs: | |
|
|
||
| - name: Build and test | ||
| run: | | ||
| export EXPERIMENTAL_MODE=true | ||
| export CCACHE_DIR=${{ runner.temp }}/ccache | ||
| scripts/third_party/travis/retry.sh scripts/build.sh Firestore ${{ runner.os }} cmake | ||
|
|
||
|
|
@@ -298,7 +297,6 @@ jobs: | |
|
|
||
| - name: Build and test | ||
| run: | | ||
| export EXPERIMENTAL_MODE=true | ||
| export CCACHE_DIR=${{ runner.temp }}/ccache | ||
| scripts/third_party/travis/retry.sh scripts/build.sh Firestore ${{ runner.os }} cmake | ||
|
|
||
|
|
@@ -350,7 +348,6 @@ jobs: | |
|
|
||
| - name: Build and test | ||
| run: | | ||
| export EXPERIMENTAL_MODE=true | ||
| export CCACHE_DIR=${{ runner.temp }}/ccache | ||
| scripts/third_party/travis/retry.sh scripts/build.sh Firestore ${{ runner.os }} cmake | ||
|
|
||
|
|
@@ -380,7 +377,6 @@ jobs: | |
|
|
||
| - name: Build and test | ||
| run: | | ||
| export EXPERIMENTAL_MODE=true | ||
| scripts/third_party/travis/retry.sh scripts/build.sh Firestore ${{ matrix.target }} xcodebuild | ||
|
|
||
| pod_lib_lint: | ||
|
|
@@ -512,37 +508,6 @@ jobs: | |
| platforms: iOS | ||
| buildonly_platforms: iOS | ||
|
|
||
| check-firestore-internal-public-headers: | ||
|
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Remove these check since right now the not all of public APIs of objective C files are intend to use by customers. |
||
| needs: check | ||
| # Either a scheduled run from public repo, or a pull request with firestore changes. | ||
| if: | | ||
| (github.repository == 'Firebase/firebase-ios-sdk' && github.event_name == 'schedule') || | ||
| (github.event_name == 'pull_request' && needs.changes.outputs.changed == 'true') | ||
| runs-on: macos-14 | ||
| steps: | ||
| - uses: actions/checkout@v4 | ||
| - name: Assert that Firestore and FirestoreInternal have identically named headers. | ||
| run: | | ||
| fst_dir=Firestore/Source/Public/FirebaseFirestore/ | ||
| fst_internal_dir=FirebaseFirestoreInternal/FirebaseFirestore/ | ||
|
|
||
| comparison=$(comm -3 <(ls $fst_dir | sort) <(ls $fst_internal_dir | sort)) | ||
|
|
||
| if [[ -z "$comparison" ]]; then | ||
| echo "Success: Directories '$fst_dir' and '$fst_internal_dir' match." | ||
| else | ||
| echo "Error: Directories '$fst_dir' and '$fst_internal_dir' differ:" | ||
| echo "Files only in '$fst_dir':" | ||
| # Files in this set do not start with whitespace. Grep for them and a | ||
| # dashed prefix for nicer formatting. | ||
| echo "$comparison" | grep -v '^\s' | sed 's/^/- /' | ||
| echo "Files only in '$fst_internal_dir':" | ||
| # Files in this set start with whitespace. Grep for them and a dashed | ||
| # prefix for nicer formatting. | ||
| echo "$comparison" | grep '^\s' | sed 's/^ /- /' | ||
| exit 1 | ||
| fi | ||
|
|
||
| # TODO: Re-enable either in or after #11706. | ||
| # spm-source-cron: | ||
| # # Don't run on private repo. | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -501,7 +501,7 @@ - (void)openDatabase { | |
| #ifdef SQLITE_OPEN_FILEPROTECTION_NONE | ||
| flags |= SQLITE_OPEN_FILEPROTECTION_NONE; | ||
| #endif | ||
| int result = sqlite3_open_v2([path UTF8String], &self -> _database, flags, NULL); | ||
| int result = sqlite3_open_v2([path UTF8String], &self->_database, flags, NULL); | ||
|
||
| if (result != SQLITE_OK) { | ||
| NSString *errorString = FIRMessagingStringFromSQLiteResult(result); | ||
| NSString *errorMessage = [NSString | ||
|
|
@@ -522,7 +522,7 @@ - (void)openDatabase { | |
| #ifdef SQLITE_OPEN_FILEPROTECTION_NONE | ||
| flags |= SQLITE_OPEN_FILEPROTECTION_NONE; | ||
| #endif | ||
| int result = sqlite3_open_v2([path UTF8String], &self -> _database, flags, NULL); | ||
| int result = sqlite3_open_v2([path UTF8String], &self->_database, flags, NULL); | ||
| if (result != SQLITE_OK) { | ||
| NSString *errorString = FIRMessagingStringFromSQLiteResult(result); | ||
| NSString *errorMessage = | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,3 +1,8 @@ | ||
| # Unreleased | ||
| - [feature] Add `Pipeline` support. | ||
|
||
| - [fixed] Fixed an issue where the returned object in transaction blocks could not | ||
| pass across actor boundaries in Swift 6 (#15467). | ||
|
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. |
||
|
|
||
| # 12.4.0 | ||
| - [fixed] Implemented an internal workaround to fix | ||
| [CVE-2025-0838](https://nvd.nist.gov/vuln/detail/CVE-2025-0838). (#15300) | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks this this flag was added by mistake in MIEQ PR: 8d66bdc The intention of the given commit is to use latest emulator. So I remove these
export EXPERIMENTAL_MODE=truehere.