Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(py): Local Vector Store Plugin #2379

Merged
merged 2 commits into from
Mar 28, 2025
Merged

feat(py): Local Vector Store Plugin #2379

merged 2 commits into from
Mar 28, 2025

Conversation

kirgrim
Copy link
Contributor

@kirgrim kirgrim commented Mar 19, 2025

Description:

  • added Dev Local Vector Store plugin
  • added define_indexer api to Genkit Registry

Checklist (if applicable):

@github-actions github-actions bot added docs Improvements or additions to documentation feature New feature or request python Python config labels Mar 19, 2025
@pavelgj pavelgj requested a review from ssbushi March 19, 2025 14:47
@kirgrim kirgrim force-pushed the hrymailo/feat/local-vector-store branch from 104aa82 to ab1996f Compare March 19, 2025 15:08
ssbushi
ssbushi requested changes Mar 19, 2025
View reviewed changes
Copy link
Contributor

@ssbushi ssbushi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We decided not to include indexer in python.... @pavelgj

@ssbushi
Copy link
Contributor

ssbushi commented Mar 19, 2025

Thanks for working on this... I was half way through the implementation before I saw this PR, maybe I should have been more vigilant in tracking this via an issue..

@kirgrim kirgrim force-pushed the hrymailo/feat/local-vector-store branch 3 times, most recently from d6a6a60 to 1882c96 Compare March 21, 2025 14:09
@kirgrim kirgrim requested a review from ssbushi March 21, 2025 14:15
@kirgrim kirgrim mentioned this pull request Mar 21, 2025
Merged
2 tasks
@kirgrim kirgrim force-pushed the hrymailo/feat/local-vector-store branch 2 times, most recently from fb3414d to 018c584 Compare March 21, 2025 14:18
@kirgrim kirgrim force-pushed the hrymailo/feat/local-vector-store branch from 018c584 to 8a103a9 Compare March 24, 2025 13:51
@kirgrim kirgrim requested review from Irillit and yesudeep March 25, 2025 12:19
@kirgrim kirgrim force-pushed the hrymailo/feat/local-vector-store branch 2 times, most recently from d2e55c1 to 20d3566 Compare March 27, 2025 13:46
@kirgrim kirgrim force-pushed the hrymailo/feat/local-vector-store branch 2 times, most recently from 730de5d to ab91db5 Compare March 28, 2025 09:57
@kirgrim kirgrim requested a review from ssbushi March 28, 2025 09:57
@kirgrim kirgrim force-pushed the hrymailo/feat/local-vector-store branch from ab91db5 to a2a2cc5 Compare March 28, 2025 10:05
@yesudeep yesudeep enabled auto-merge (squash) March 28, 2025 17:20
@yesudeep yesudeep merged commit a995b01 into main Mar 28, 2025
9 checks passed
@yesudeep yesudeep deleted the hrymailo/feat/local-vector-store branch March 28, 2025 17:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yesudeep yesudeep yesudeep approved these changes

@pavelgj pavelgj Awaiting requested review from pavelgj pavelgj is a code owner

@timere-nemo timere-nemo Awaiting requested review from timere-nemo

@kamilkorski kamilkorski Awaiting requested review from kamilkorski

@Irillit Irillit Awaiting requested review from Irillit

@ssbushi ssbushi Awaiting requested review from ssbushi

Assignees
No one assigned
Labels
config docs Improvements or additions to documentation feature New feature or request python Python
Projects
Genkit Backlog
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kirgrim @ssbushi @yesudeep @Irillit