add an header for client / server labels in the packets list#59
add an header for client / server labels in the packets list#59rpl wants to merge 5 commits intofirebug:masterfrom
Conversation
|
@captainbrosset I've just pushed this small tweak to the UI, how it looks to you? |
|
Cool, I think that helps.
|
- extract labels into locales - rename to PacketsParticipantsBar - add bottom border and box shadow to the header bar - change proposed labels to: Actors (Server) and Toolbox (Client)
1cb5bd2 to
cce12b6
Compare
|
@captainbrosset @janodvarko I've just updated this branch with the following changes:
|
|
@captainbrosset @janodvarko the screenshots in the description show the last changes |
|
Thanks for the work Luca! (sorry for the delay, back from vacation today) I share the concern related to "client/server" vs. "actors/toolbox" terminology and I am afraid that none of the suggestions makes the UI better. The original idea behind the packet-list UI/UX has been mimicking well known user-chat UI (e.g. WhatsApp, SMS clients, etc.):
Where 'me' (in our case) doesn't necessarily have to be the Toolbox. It can be any client that has a connection to the backend (or server or actors, huh). I don't know how to make this basic UX concept better to understand, but note that:
Isn't that already enough indication of what is sent and what received? We could yet change the labels to: "Received" and "Sent", but I would rather vote to not append the top bar at all. Honza |
|
@janodvarko No problem, I completely understand, and this is just a proposal, if we are unsure about how to change the UI, it is definitely better to not change it until we have a better idea. I'm going to open another pull request and cherrypick 99c6f9d which is not related to this change and fixes a visual issue on the TreeEditorView component (the remove item button disappears when the mouse is over it). |
Yes
Excellent (also see my comment in the commit) Honza |
This PR introduces: