-
-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: do not skip merge group #329
Conversation
- add `merge_group` as workflow trigger - add `merge_group` to default value sfor `do-not-skip` triggers : else, worfklow will be skipped when the PR is added to a merge queue since it just ran before
There are some checks failing. If using this PR ( `uses: wahtique/skip-duplicate-actions@2e9b67b``), I get
|
Thank you for submitting the PR! |
I cannot merge it without the compiled JS, we need the compiled JS updated for this to work |
Merged, thank you for updating the JS! |
Thanks for the PR @wahtique! Sorry for my late & post-merge comment, but
doesn't it make sense that it is skipped? 😄 |
@fkirc WDYT about this #329 (comment)? If the tree hash is the same in merge group it makes sense to skip it IMO? |
In response to #329 (comment) That was some time ago but use case was :
Possible fixes would be
|
I would agree to skip if a tree hash is in the same merge group, but I do not know how to implement it at the moment. |
1 similar comment
I would agree to skip if a tree hash is in the same merge group, but I do not know how to implement it at the moment. |
merge_group
as workflow triggermerge_group
to default value sfordo-not-skip
triggers : else, worfklow will be skipped when the PR is added to a merge queue since it just ran before