fix: skip remote Kustomizations on recursive diff #5071
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
FYI I did not make this return an error code. I think there's three reasonable options:
|
When recursively diffing Kustomization objects on a cluster, each Kustomization is built and then a server-side dry-run apply is performed. This isn't practical to perform if the Kustomization references a remote cluster via `kubeConfig.secretRef`. Currently, because it's not skipped, it's treated as though it's being applied to the context cluster, not the remote cluter, which results in an incorrect diff. Instead, write out special message / warnings indicating that it has been skipped: ``` ► Kustomization/my-ns/my-kst skipped: diff not supported for remote clusters ``` Signed-off-by: Milas Bowman <[email protected]>
milas
force-pushed
the
diff-kustomization-recursive-remote
branch
from
74aabc7
to
d7a2ffc
Compare
|
@milas can you please rebase with upstream main and force push. Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When recursively diffing Kustomization objects on a cluster, each Kustomization is built and then a server-side dry-run apply is performed. This isn't practical to perform if the Kustomization references a remote cluster via
kubeConfig.secretRef.Currently, because it's not skipped, it's treated as though it's being applied to the context cluster, not the remote cluster, which results in an incorrect diff.
Instead, write out special message / warnings indicating that it has been skipped:
See also: