Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: skip remote Kustomizations on recursive diff #5071

Merged
merged 1 commit into from
Nov 14, 2024
Merged

fix: skip remote Kustomizations on recursive diff #5071

merged 1 commit into from
Nov 14, 2024
+12 −8

Commits on Nov 14, 2024

  1. fix: skip remote Kustomizations on recursive diff 

    When recursively diffing Kustomization objects on a cluster, each
Kustomization is built and then a server-side dry-run apply is
performed. This isn't practical to perform if the Kustomization
references a remote cluster via `kubeConfig.secretRef`.

Currently, because it's not skipped, it's treated as though it's
being applied to the context cluster, not the remote cluter, which
results in an incorrect diff.

Instead, write out special message / warnings indicating that it
has been skipped:
```
► Kustomization/my-ns/my-kst skipped: diff not supported for remote clusters
```

Signed-off-by: Milas Bowman <[email protected]>
    @milas
    milas committed Nov 14, 2024
    Configuration menu
    Copy the full SHA
    7697699 View commit details
    Browse the repository at this point in the history