Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Types/generic alias - assert fix only #2743

Merged
merged 5 commits into from
Sep 14, 2024

try to fix an edge case

7a9d420
Select commit
Loading
Failed to load commit list.
Merged

Types/generic alias - assert fix only #2743

try to fix an edge case
7a9d420
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project failed Sep 11, 2024 in 0s

81.10% (-9.77%) compared to ae9c6f8

View this Pull Request on Codecov

81.10% (-9.77%) compared to ae9c6f8

Details

Codecov Report

Attention: Patch coverage is 82.85714% with 6 lines in your changes missing coverage. Please review.

Project coverage is 81.10%. Comparing base (ae9c6f8) to head (7a9d420).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
flytekit/core/type_engine.py 82.85% 3 Missing and 3 partials ⚠️

❗ There is a different number of reports uploaded between BASE (ae9c6f8) and HEAD (7a9d420). Click for more details.

HEAD has 7 uploads less than BASE
Flag BASE (ae9c6f8) HEAD (7a9d420)
15 8
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2743      +/-   ##
==========================================
- Coverage   90.87%   81.10%   -9.77%     
==========================================
  Files          74      194     +120     
  Lines        3331    19756   +16425     
  Branches        0     4120    +4120     
==========================================
+ Hits         3027    16023   +12996     
- Misses        304     2991    +2687     
- Partials        0      742     +742     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.