FIO-9942: apply evaluator override properties to fix interpolation is…#6203
Closed
Maria-Golomb wants to merge 2 commits intomasterfrom
Closed
FIO-9942: apply evaluator override properties to fix interpolation is…#6203Maria-Golomb wants to merge 2 commits intomasterfrom
Maria-Golomb wants to merge 2 commits intomasterfrom
Conversation
brendanbond
requested changes
Aug 1, 2025
| * @returns {void} | ||
| */ | ||
| export function registerEvaluator(override) { | ||
| if(override.noeval){ |
Contributor
There was a problem hiding this comment.
Can't we just make the Protected-Eval Evaluator class inherit from the base class that's now in @formio/core? That seems safer to me (and more type safe at the end of the day!) than just trying to copy parameters and hope they exist
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…sues
Link to Jira Ticket
https://formio.atlassian.net/browse/FIO-9942
Description
Copy override evaluator noeval properte to DefaultEvaluator instance to prevent CSP errors from lodash template function during interpolation. Restores formiojs 4.x behavior.
Breaking Changes / Backwards Compatibility
Dependencies
How has this PR been tested?
manually
Checklist: