Skip to content

FIO-9942: apply evaluator override properties to fix interpolation is… #6203

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Maria-Golomb wants to merge 2 commits into from
Closed

FIO-9942: apply evaluator override properties to fix interpolation is… #6203

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a562b12
FIO-9942: apply evaluator override properties to fix interpolation is…
Maria-Golomb Jul 31, 2025
fca166f
Merge remote-tracking branch 'origin/master' into FIO-9942-noeval-opt…
lane-formio Aug 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions src/utils/Evaluator.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,5 +74,8 @@ export function interpolate(...args) {
* @returns {void}
*/
export function registerEvaluator(override) {
if(override.noeval){
Copy link
Copy Markdown
Contributor

@brendanbond brendanbond Aug 1, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can't we just make the Protected-Eval Evaluator class inherit from the base class that's now in @formio/core? That seems safer to me (and more type safe at the end of the day!) than just trying to copy parameters and hope they exist

Evaluator.noeval = override.noeval
}
Evaluator = override;
}