Fix negative timestamps when using secretsdump local on windows #2069
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using secrestdump SAM dump on Windows (e.g.
--sam secdumpor thebackup_operatormodule) secretsdump crashes. This is due to the negative timestamp that is passed into datetime which can't be handled on windows:This happens when the
userAccountF['LastIncorrectPasswordTimestamp']is zero in nt time and is then converted to a negative unixTimestamp integer. This can easily be fixed by manually returning the 0 nt timestamp on when the input is 0.Before:


After: