Skip to content

Fix negative timestamps when using secretsdump local on windows #2069

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix negative timestamps when using secretsdump local on windows #2069

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions impacket/examples/secretsdump.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1458,8 +1458,13 @@ def nt_time_to_datetime(self, nt_time):
# NT Time is in 100-nanosecond intervals since 1601-01-01 (UTC)
# The difference between 1601 and 1970 is 11644473600 seconds
nt_time = int.from_bytes(nt_time, byteorder='little') # Convert byte string to integer
unix_time = (nt_time - 116444736000000000) // 10000000 # Convert to Unix time (seconds)
return datetime.utcfromtimestamp(unix_time)

# datetime on windows can't handle negative timestamps (i.e. before 1970), therefore we must return the 0 time directly
if nt_time == 0:
return datetime(1601, 1, 1, 0, 0, 0)
else:
unix_time = (nt_time - 116444736000000000) // 10000000 # Convert to Unix time (seconds)
return datetime.utcfromtimestamp(unix_time)

def MD5(self, data):
md5 = hashlib.new('md5')
Expand Down