Draft: Metapackage for NetCDF #1120
Open
+2,238
−1,895
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
krystophny
force-pushed
the
metapackage_netcdf
branch
2 times, most recently
from
53f90ed to
c2fea1d
Compare
This was referenced Apr 5, 2025
krystophny
force-pushed
the
metapackage_netcdf
branch
from
0593b5c to
15d4e0b
Compare
krystophny
force-pushed
the
metapackage_netcdf
branch
from
15d4e0b to
6a61a70
Compare
|
... on hold for now, the tokenization of the flags still causes some issues. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is based on the refactored version of #1119 . Apply once #1119 is merged. Docs in fortran-lang/fpm-docs#160
Besides NetCDF support and refactoring the way pkg-config is used from there and HDF5, there are modifications on the way flags are handled. Now all are converted from strings to arrays on the way. This was required because Intel Fortran dies on empty "-I" flags returned by pkg-config. In addition that allowed to avoid duplicate flags - a feature that could later be added more generally (there are a few also generated in other parts of the code, see
fpm build --verbose) @perazz if you have time, please check if I use yoursplitfunction correctly.