-
Notifications
You must be signed in to change notification settings - Fork 109
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[metapackage] BLAS #1121
base: main
Are you sure you want to change the base?
[metapackage] BLAS #1121
Conversation
d092129
to
11e0295
Compare
11e0295
to
c4ce1f4
Compare
2f98109
to
a339e69
Compare
Oh, I see now that Windows tests are merged from |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work @krystophny. Of course there are plenty BLAS/LAPACK versions, and this will grow with time, but it's a good way to begin supporting BLAS/LAPACK as a metapackage imho.
src/metapackage/fpm_meta_blas.f90
Outdated
this%flags = string_t("-framework Accelerate") | ||
this%has_build_flags = .true. | ||
this%link_flags = string_t("-framework Accelerate") | ||
this%has_link_flags = .true. | ||
return |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Most macOS versions (>=10.15
) will have Accelerate, but there are users that employ very old versions as well. Should we attempt introspection #1128 first to check whether Accelerate is supported?
this%flags = string_t("-framework Accelerate") | |
this%has_build_flags = .true. | |
this%link_flags = string_t("-framework Accelerate") | |
this%has_link_flags = .true. | |
return | |
if (.not.compiler%check_flags_supported( & | |
compile_flags="-framework Accelerate", & | |
link_flags="-framework Accelerate")) then | |
call fatal_error(error,'no Accelerate framework detected on the local system') | |
return | |
endif | |
this%flags = string_t("-framework Accelerate") | |
this%has_build_flags = .true. | |
this%link_flags = string_t("-framework Accelerate") | |
this%has_link_flags = .true. | |
return |
Note that we don't necessarily have to return with an error, we could just fallback to the pkg-config evaluation as a second choice. The same could be done for MKL and the Intel compilers.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree we should check this and opted for the pkg-config fallback solution now. Let's see if all tests still pass.
8c67557
to
c137d7d
Compare
Tests are passing, should be fine to merge now. |
Co-authored-by: Federico Perini <[email protected]>
de36c63
to
c29932a
Compare
Merge after #1120 and fixing Intel and Mac (probably with MKL and Accelerate BLAS)