Skip to content

✨ feat(tests): EIP-7928 tests for coinbase, withdrawal, storage, and account access #23

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 26 commits into from
Closed

✨ feat(tests): EIP-7928 tests for coinbase, withdrawal, storage, and account access #23

wants to merge 26 commits into from

Conversation

@raxhvl
Copy link
Collaborator

@raxhvl raxhvl commented Oct 29, 2025 •
edited
Loading

Adds new EIP-7928 test cases for Coinbase, withdrawal, edge cases for storage and account access.

Tests

Coinbase

  1. test_bal_empty_block_no_coinbase
  2. test_bal_coinbase_zero_tip

EIP-4895 Withdrawal

  1. test_bal_withdrawal_empty_block
  2. test_bal_withdrawal_and_transaction
  3. test_bal_withdrawal_to_nonexistent_account
  4. test_bal_withdrawal_no_evm_execution
  5. test_bal_withdrawal_and_state_access_same_account
  6. test_bal_withdrawal_and_value_transfer_same_address
  7. test_bal_multiple_withdrawals_same_address
  8. test_bal_withdrawal_and_selfdestruct
  9. test_bal_withdrawal_and_new_contract
  10. test_bal_zero_withdrawal
  11. test_bal_withdrawal_to_precompiles
  12. test_bal_withdrawal_largest_amount
  13. test_bal_withdrawal_to_coinbase
  14. test_bal_withdrawal_to_coinbase_empty_block

Precompiles

  1. test_bal_precompile_funded
  2. test_bal_precompile_call

Non-existent accounts

  1. test_bal_nonexistent_value_transfer
  2. test_bal_nonexistent_account_access

Storage edge cases

  1. test_bal_storage_write_read_same_frame
  2. test_bal_storage_write_read_cross_frame

Blockers

@cr-gpt
Copy link

cr-gpt bot commented Oct 29, 2025

Seems you are using me but didn't get OPENAI_API_KEY seted in Variables/Secrets for this repo. you could follow readme for more information

@raxhvl raxhvl changed the title ✨ feat(tests): EIP-7928 tests for coinbase, withdrawal, storage, and account access feat(tests): ✨ EIP-7928 tests for coinbase, withdrawal, storage, and account access Oct 29, 2025
@raxhvl raxhvl changed the title feat(tests): ✨ EIP-7928 tests for coinbase, withdrawal, storage, and account access ✨ feat(tests): EIP-7928 tests for coinbase, withdrawal, storage, and account access Oct 29, 2025
Repository owner deleted a comment from cr-gpt bot Oct 29, 2025
Repository owner deleted a comment from cr-gpt bot Oct 29, 2025
Repository owner deleted a comment from cr-gpt bot Oct 29, 2025
@nerolation nerolation mentioned this pull request Oct 29, 2025
Closed
@cr-gpt
Copy link

cr-gpt bot commented Oct 29, 2025

Seems you are using me but didn't get OPENAI_API_KEY seted in Variables/Secrets for this repo. you could follow readme for more information

@cr-gpt
Copy link

cr-gpt bot commented Oct 29, 2025

Seems you are using me but didn't get OPENAI_API_KEY seted in Variables/Secrets for this repo. you could follow readme for more information

@cr-gpt
Copy link

cr-gpt bot commented Oct 29, 2025

Seems you are using me but didn't get OPENAI_API_KEY seted in Variables/Secrets for this repo. you could follow readme for more information

@fselmo fselmo mentioned this pull request Oct 29, 2025
Merged
fselmo
fselmo approved these changes Oct 29, 2025
View reviewed changes
Copy link
Owner

@fselmo fselmo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@raxhvl I added some fixes to this but this has everything passing after #29 gets in. I will wait for that and then we can merge this. Thanks for all the work here! 👍🏼

@fselmo
Copy link
Owner

fselmo commented Oct 30, 2025

@raxhvl can you fix the static lint issues here?

@raxhvl
Copy link
Collaborator Author

raxhvl commented Oct 30, 2025

Hey @fselmo fixed the static issue, I have few more new tests since your review:

❇️

Withdrawal

  1. test_bal_withdrawal_to_precompiles
  2. test_bal_withdrawal_largest_amount
  3. test_bal_withdrawal_to_coinbase
  4. test_bal_withdrawal_to_coinbase_empty_block

Precompiles

  1. test_bal_precompile_funded
  2. test_bal_precompile_call

Non-existent accounts

  1. test_bal_nonexistent_value_transfer
  2. test_bal_nonexistent_account_access

Storage edge cases

  1. test_bal_storage_write_read_same_frame
  2. test_bal_storage_write_read_cross_frame

I'm done adding tests now - Once all issues are closed feel free to merge the tests if everything passes. Could you also carefully review the coinbase once before merging? Thanks!

raxhvl added 12 commits October 30, 2025 14:28
fselmo and others added 12 commits October 30, 2025 14:28
@fselmo
fix(specs,tests): Fix withdrawal tests for BALs issue with idx==0
193543b 
- `self.txs.successfully_parsed` is a list of transaction indexes, not
  transactions. The "if tx" check here would then check `if 0` which
  parses as a boolean ``False``. This means we would skip counting the tx
  if index=0 was successful.

- Fixes some test expectations where `post_code` was being checked instead
  of ``new_code``.
@fselmo
fix(tests): expectation for nonexistent account in post
f2813aa
@raxhvl @fselmo
feat(tests): EIP-7928 test_bal_withdrawal_to_precompiles
18f294c
@raxhvl @fselmo
feat(tests): EIP-7928 test_bal_withdrawal_largest_amount
5822ea3
@raxhvl @fselmo
feat(tests): EIP-7928 test_bal_withdrawal_to_coinbase
61450b5
@raxhvl @fselmo
feat(tests): EIP-7928 test_bal_withdrawal_to_coinbase_empty_block
b3dd4d6
@raxhvl @fselmo
feat(tests): EIP-7928 test_bal_precompiles
d25d612
@raxhvl @fselmo
feat(tests): EIP-7928 test_bal_nonexistent_value_transfer
ddb7db4
@raxhvl @fselmo
feat(tests): EIP-7928 test_bal_nonexistent_account_access
bf9f2c7
@raxhvl @fselmo
feat(tests): EIP-7928 test_bal_storage_write_read_same_frame
70aebee
@raxhvl @fselmo
feat(tests): EIP-7928 test_bal_storage_write_read_cross_frame
c8f660b
@raxhvl @fselmo
chore(tests): linting fixes
ee14d6c
@fselmo
Copy link
Owner

fselmo commented Oct 30, 2025 •
edited
Loading

@raxhvl this looks good to me now. I fixed the issues with the precompile tests here (the tests were wrong, not the specs) and I split the test that was using pytest.skip because I don't think we should have this built into tests. Please make sure this looks good to you here and if so I'm good to merge this so we can move this feature branch over to ethereum/execution-specs as branch eips/amsterdam/eip-7928 so we can start to release from there. The reason for this is we need the feature branch to be part of ethereum/execution-specs rather than my fork (fselmo/execution-specs).

@raxhvl
Copy link
Collaborator Author

raxhvl commented Oct 31, 2025

Hey @fselmo - The changes look good to me, all tests are now passing, you can merge this 👍

@fselmo
Copy link
Owner

fselmo commented Oct 31, 2025

@raxhvl I've created the branch to execution-specs here with these changes in there! Going to close this as we're all caught up there now.

@fselmo fselmo closed this Oct 31, 2025
@nerolation nerolation mentioned this pull request Oct 31, 2025
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@fselmo fselmo fselmo approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@raxhvl @fselmo