fix(specs): Fix zero value withdrawals BAL tracking #29
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fselmo
force-pushed
the
fix/withdrawals-zero-transfer
branch
from
8c6b852 to
9fce100
Compare
4 tasks
Collaborator
|
I'm fine using "normalize", no strong opinion on it, but would "filtering" be more accurate? |
nerolation
force-pushed
the
fix/withdrawals-zero-transfer
branch
from
02e6602 to
4b7ec5c
Compare
3 tasks
Owner
Author
|
@nerolation I'm good with |
Collaborator
|
No strong opinion. Let's keep it as-is for now and we could still change the variable name later on. |
fselmo
merged commit ac6739a
into
feat/amsterdam-fork-and-block-access-lists
4 of 10 checks passed
Owner
Author
|
Sounds good. Merged! |
fselmo
added a commit
that referenced
this pull request
Oct 31, 2025
* fix(specs): Fix zero value withdrawals BAL tracking * docs(specs): rename 'finalize' to 'normalize' in comments * docs(specs): remove reference to uint128 for balance tracking --------- Co-authored-by: Toni Wahrstätter <[email protected]> Co-authored-by: Toni Wahrstätter <[email protected]>
fselmo
added a commit
that referenced
this pull request
Nov 4, 2025
* fix(specs): Fix zero value withdrawals BAL tracking * docs(specs): rename 'finalize' to 'normalize' in comments * docs(specs): remove reference to uint128 for balance tracking --------- Co-authored-by: Toni Wahrstätter <[email protected]> Co-authored-by: Toni Wahrstätter <[email protected]>
fselmo
added a commit
that referenced
this pull request
Nov 4, 2025
* fix(specs): Fix zero value withdrawals BAL tracking * docs(specs): rename 'finalize' to 'normalize' in comments * docs(specs): remove reference to uint128 for balance tracking --------- Co-authored-by: Toni Wahrstätter <[email protected]> Co-authored-by: Toni Wahrstätter <[email protected]>
fselmo
added a commit
that referenced
this pull request
Nov 11, 2025
* fix(specs): Fix zero value withdrawals BAL tracking * docs(specs): rename 'finalize' to 'normalize' in comments * docs(specs): remove reference to uint128 for balance tracking --------- Co-authored-by: Toni Wahrstätter <[email protected]> Co-authored-by: Toni Wahrstätter <[email protected]>
fselmo
added a commit
that referenced
this pull request
Nov 11, 2025
* fix(specs): Fix zero value withdrawals BAL tracking * docs(specs): rename 'finalize' to 'normalize' in comments * docs(specs): remove reference to uint128 for balance tracking --------- Co-authored-by: Toni Wahrstätter <[email protected]> Co-authored-by: Toni Wahrstätter <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was wrong?
closes #27
How was it fixed?
Make the
finalize_transaction_changesmore generic asnormalize_balance_changes. Call this after withdrawals which normalize if pre == post to not be included as a change.We only have two tests failing after this in #23 for withdrawals with zero value to non-existent accounts. The test expects the account to be in the BAL with empty changes, is this the expected behavior?^ fixed the last 2 fails here. Everything is passing for me after these changes, let's just make sure this is how we want to implement it @raxhvl @nerolation
Cute Animal Picture
🐇