feat!: add GRANTED_BROWSER_PROFILE env var support for browser profile override

[billyjbryant]

Details

Add support for GRANTED_BROWSER_PROFILE and GRANTED_SSO_BROWSER_PROFILE environment variables to override the browser profile used when opening AWS console and during SSO login flows.

Fixes #886

Changes

Browser Profile for Console Access (GRANTED_BROWSER_PROFILE)

• Add EnvVars to --browser-profile flag to automatically read from GRANTED_BROWSER_PROFILE environment variable
• Remove browser-profile from getConsoleURL condition to prevent env var from inadvertently triggering console URL generation
• Browser profile from env var is only used when actually launching browser (after all safety checks)

SSO Browser Profile (GRANTED_SSO_BROWSER_PROFILE)

• Add --sso-browser-profile flag to assume, granted sso login, granted sso generate, and granted sso populate commands
• Add SSOBrowserProfile field to ConfigOpts to pass browser profile through SSO login flow
• Support GRANTED_SSO_BROWSER_PROFILE environment variable via flag EnvVars
• Add test case for empty browser profile in launcher tests

Breaking Changes

The --browser-profile flag no longer triggers browser opening by itself.

Users must now explicitly use -c or -s flags along with --browser-profile to open a browser with the desired profile.

Previously, passing --browser-profile alone would open a browser window, but now it only sets which browser profile to use when a browser is opened via other flags. This prevents the GRANTED_BROWSER_PROFILE environment variable from inadvertently opening browsers.

Usage

Console Browser Profile

Users can now set a default browser profile via environment variable for console access:

export GRANTED_BROWSER_PROFILE="MyBrowserProfile"
assume -c my-aws-profile  # Will use "MyBrowserProfile" as the browser profile

The --browser-profile flag still takes precedence over the environment variable.

SSO Browser Profile

Users can set a default browser profile for SSO login flows:

export GRANTED_SSO_BROWSER_PROFILE="MySSOProfile"
granted sso login  # Will use "MySSOProfile" for SSO authentication
assume --sso --sso-start-url https://example.awsapps.com/start  # Will use "MySSOProfile"

Or use the flag directly:

granted sso login --sso-browser-profile MySSOProfile
assume --sso --sso-browser-profile MySSOProfile --sso-start-url https://example.awsapps.com/start

The --sso-browser-profile flag takes precedence over the GRANTED_SSO_BROWSER_PROFILE environment variable.

Testing

• Added test case for empty browser profile in launcher tests
• All existing tests continue to pass

BREAKING CHANGE: The --browser-profile flag no longer triggers browser opening by itself. Users must now explicitly use -c or -s flags along with --browser-profile to open a browser with the desired profile.

[meyerjrr]

Thanks for the contribution @billyjbryant !

On the fence on the decision to make the breaking change to make browser-profile no longer open the console as users may already have using this in their workflows to open to a profile, like noted in the tracked issue.

What if we added this as a setting to the granted config as default-browser-profile. That way we would not have to interfere with the existing UX of the flag but enable users to specify a profile to always open up into.

What are your thoughts on this?

[billyjbryant]

On the fence on the decision to make the breaking change to make browser-profile no longer open the console as users may already have using this in their workflows to open to a profile, like noted in the tracked issue.

Isn't that kind of a side effect? I honestly wouldn't expect that to be a "feature" that calling --browser-profile without --console or --service would open the console. I almost wouldn't have expected the cli to accept --browser-profile without the other two.

I'm ok to tweak; however, if we feel that the change would be disruptive, I'm happy to entertain other options.

[meyerjrr]

@billyjbryant On second thought, I agree with where you're coming from here. --browser-profile does feel more like an additive flag to be used in conjunction with -c

Again thanks for the contribution!