Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Workflow Editor Activity Bar #18729

Open
wants to merge 77 commits into
base: dev
Choose a base branch
from

Conversation

ElectronicBlueberry
Copy link
Member

@ElectronicBlueberry ElectronicBlueberry commented Aug 22, 2024

Brings the activity bar to the workflow editor.
Early stages, but open for suggestions

image

Planned activities for this PR:

  • changes (undo redo stack ui)
  • workflows (to insert like tools)

Ideas for additional activities, but unsure about:

  • workflow specific utility tools
  • workflow attributes
    this would free up the right panel to serve a single purpose
  • step list
  • subworkflows (in this workflow)
  • invocations of this workflow
  • run with simplified run form
  • edit report

How to test the changes?

(Select all options that apply)

  • I've included appropriate automated tests.
  • This is a refactoring of components with existing test coverage.
  • Instructions for manual testing are as follows:
    1. [add testing steps and prerequisites here if you didn't write automated tests covering all your changes]

License

  • I agree to license these and all my past contributions to the core galaxy codebase under the MIT license.

@ahmedhamidawan
Copy link
Member

This might tie in nicely with the ideas in #18166?

@bgruening
Copy link
Member

The first round of feedback:

  • separate "inputs" from tools, inputs are imho equivalent to "Upload"
  • An easy way to exit is missing imho, "save and exit" instead of "save" might be an option, especially since we now have the "changes" option
  • if there are no "workflows" then a hint should be shown like "Here are all workflows listed that you can include as sub-workflows"
  • Q: is it useful to list the self-workflow? Is that even possible to include them in a workflow? Recursion?
  • Should Ctrl+S save the workflow?
  • if you click on tools, the focus should be on the search-box

Thanks @ElectronicBlueberry!

@ahmedhamidawan ahmedhamidawan linked an issue Nov 3, 2024 that may be closed by this pull request
@bgruening
Copy link
Member

Thanks a lot, Laila. Here is a small review from Wolfgang and me from the Biohackathon:

  • If I click tools, my cursor should be in the search field
  • If I click on " Input dataset: Missing a label and annotation " in the best-practise panel, its not clear which node is selected and I should probably see the left-side panel?
  • if I save the "changes" disappear, this makes somehow sense, but its a bit confusing as the "changes" panel is then empty. Should we indicate the "versions" also in the changes panel?
    • if we move the version into the "changes" panel we could rename "Attributes" to Description?
  • I'm not convinced "auto-layout", "upgrade" and "download" deserves its own panel item
    • separate them with another horizontal bar?
    • should auto-layout be part of the "annotation toolbar"
    1. make sure the left panel is not shown, 2) move some boxes, 3) click the arrows (upper, left corner) to revert changes -> the left panel will open, which I think is wrong
  • should "Inputs" in the tool panel be its own activity bar item?
  • Best Practices Review is not scrollable
  • The Run option should be moved to just above Save&Exit
  • Downloads triggers a "leave page" warning - but we do not leave the page
  • we propose: tools, workflows on top, a horizontal bar and then the rest of the items which are more "metadata inspection items"
  • auto-layout can not be undone

@dannon dannon added this to the 24.2 milestone Nov 12, 2024
@dannon dannon marked this pull request as ready for review November 12, 2024 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

move workflow editor actions out of the toolform
4 participants