-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Workflow Editor Activity Bar #18729
Open
ElectronicBlueberry
wants to merge
77
commits into
galaxyproject:dev
Choose a base branch
from
ElectronicBlueberry:workflow-editor-activity-bar
base: dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Workflow Editor Activity Bar #18729
ElectronicBlueberry
wants to merge
77
commits into
galaxyproject:dev
from
ElectronicBlueberry:workflow-editor-activity-bar
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This might tie in nicely with the ideas in #18166? |
ElectronicBlueberry
force-pushed
the
workflow-editor-activity-bar
branch
from
September 2, 2024 13:34
aace313
to
c0f98fa
Compare
The first round of feedback:
Thanks @ElectronicBlueberry! |
ElectronicBlueberry
force-pushed
the
workflow-editor-activity-bar
branch
from
October 8, 2024 12:04
0b346aa
to
8d4be70
Compare
ElectronicBlueberry
force-pushed
the
workflow-editor-activity-bar
branch
from
October 25, 2024 14:06
7258f47
to
be0d6d5
Compare
4 tasks
debounce sync to avoid staggered calls pass activity bar id where needed
make delayed input v-model compliant
add types fix type errors remove redundant code remove any unify naming
make workflow card mostly stateless move modals outside of workflow card
add missing actions to dropdown
remove unused css fix broken css add non-found indicator
ElectronicBlueberry
force-pushed
the
workflow-editor-activity-bar
branch
from
October 31, 2024 16:02
87fc317
to
7f4b0b8
Compare
Thanks a lot, Laila. Here is a small review from Wolfgang and me from the Biohackathon:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Brings the activity bar to the workflow editor.
Early stages, but open for suggestions
Planned activities for this PR:
Ideas for additional activities, but unsure about:
this would free up the right panel to serve a single purpose
How to test the changes?
(Select all options that apply)
License