Add option to enable GxITs in planemo serve #1568
Conversation
|
Here it is. Thanks @bernt-matthias |
There was a problem hiding this comment.
Thanks for working this out. I would make this the default with an option to disable interactive tools, planemo is for development, I don't think there's any harm in enabling ITs by default. However I would attempt binding a random gxit port, get_free_port in planemo.network_util can help you there.
planemo/galaxy/config.py
Outdated
| properties.update( | ||
| dict( | ||
| interactivetools_enable="True", | ||
| interactivetools_map="database/interactivetools_map.sqlite", |
There was a problem hiding this comment.
| interactivetools_map="database/interactivetools_map.sqlite", |
i wouldn't specify default values
planemo/galaxy/config.py
Outdated
| if kwds.get("enable_gxits", True): | ||
| properties.update( | ||
| dict( | ||
| interactivetools_enable="True", |
There was a problem hiding this comment.
| interactivetools_enable="True", | |
| interactivetools_enable="true", |
planemo/galaxy/config.py
Outdated
| interactivetools_enable="True", | ||
| interactivetools_map="database/interactivetools_map.sqlite", | ||
| galaxy_infrastructure_url="http://localhost:8080", | ||
| interactivetools_upstream_proxy="False", |
There was a problem hiding this comment.
| interactivetools_upstream_proxy="False", | |
| interactivetools_upstream_proxy="false", |
planemo/galaxy/config.py
Outdated
| dict( | ||
| interactivetools_enable="True", | ||
| interactivetools_map="database/interactivetools_map.sqlite", | ||
| galaxy_infrastructure_url="http://localhost:8080", |
There was a problem hiding this comment.
You'll need to template this with the actual port
There was a problem hiding this comment.
used the {template_args['port']}
planemo/galaxy/config.py
Outdated
| interactivetools_map="database/interactivetools_map.sqlite", | ||
| galaxy_infrastructure_url="http://localhost:8080", | ||
| interactivetools_upstream_proxy="False", | ||
| interactivetools_proxy_host="localhost:4002", |
There was a problem hiding this comment.
You can use get_free_port to find a random port on the host
There was a problem hiding this comment.
I used and tested locally with get_free_port and it works!
2 participants
It is implemented as an option for the
servecommand. It can also be enabled by default if it is fine.