-
Notifications
You must be signed in to change notification settings - Fork 95
Add option to enable GxITs in planemo serve #1568
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Changes from 3 commits
b80f866
7f4b3b5
c09ee7f
8061ed9
65dfa62
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
|
|
@@ -425,6 +425,16 @@ def config_join(*args): | |||||
| properties["database_connection"] = _database_connection(database_location, **kwds) | ||||||
| if kwds.get("mulled_containers", False): | ||||||
| properties["mulled_channels"] = kwds.get("conda_ensure_channels", "") | ||||||
| if kwds.get("enable_gxits", True): | ||||||
| properties.update( | ||||||
| dict( | ||||||
| interactivetools_enable="True", | ||||||
| interactivetools_map="database/interactivetools_map.sqlite", | ||||||
|
||||||
| interactivetools_map="database/interactivetools_map.sqlite", |
i wouldn't specify default values
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You'll need to template this with the actual port
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
used the {template_args['port']}
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| interactivetools_upstream_proxy="False", | |
| interactivetools_upstream_proxy="false", |
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can use get_free_port to find a random port on the host
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I used and tested locally with get_free_port and it works!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.