Skip to content

Conversation

aaronfern
Copy link
Contributor

What this PR does / why we need it:
We sometimes have a case where the PreferNoSchedule taint can remain indefinitely on nodes if we backtrack on a rolling update
This PR adds a check to remove this taint from nodes after a rolling update is complete

Which issue(s) this PR fixes:
Fixes #989

Special notes for your reviewer:

Release note:

NONE

@aaronfern aaronfern requested a review from a team as a code owner June 2, 2025 12:21
@aaronfern aaronfern marked this pull request as draft June 2, 2025 12:21
@gardener-robot gardener-robot added the needs/review Needs review label Jun 2, 2025
@gardener-robot-ci-3 gardener-robot-ci-3 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Jun 2, 2025
@gardener-robot gardener-robot added the size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py) label Jun 2, 2025
@gardener-robot-ci-3 gardener-robot-ci-3 added needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Jun 2, 2025
@aaronfern aaronfern marked this pull request as ready for review June 2, 2025 14:48
@gardener-robot-ci-3 gardener-robot-ci-3 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Jul 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) needs/review Needs review reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

prefer-no-schedule taint sticks forever if oldMS --> newMS --> oldMS
4 participants