Skip to content

Check and remove PreferNoSchedule taint from nodes after rolling update #1001

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Check and remove PreferNoSchedule taint from nodes after rolling update #1001

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions pkg/controller/deployment_rolling.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -114,6 +114,19 @@ func (dc *controller) rolloutRolling(ctx context.Context, d *v1alpha1.MachineDep
return err
}
}
// This check is needed because sometimes we can backtrack on a deployment, and this taint can stick
// See https://github.com/gardener/machine-controller-manager/issues/989 for more details
if err = dc.removeTaintNodesBackingMachineSet(
ctx,
newIS,
&v1.Taint{
Key: PreferNoScheduleKey,
Value: "True",
Effect: "PreferNoSchedule",
},
); err != nil {
klog.Warningf("Failed to remove taint %s from all nodes. Error: %s", PreferNoScheduleKey, err)
}
if err := dc.cleanupMachineDeployment(ctx, oldISs, d); err != nil {
return err
}
Expand Down
Loading